Skip to content

[19.0][FIX] web_view_google_map: prompt for API key instead of Google JS error - #470

Merged
OCA-git-bot merged 1 commit into
OCA:19.0from
ursais:19.0-fix-web_view_google_map-api-key-prompt
Aug 1, 2026
Merged

[19.0][FIX] web_view_google_map: prompt for API key instead of Google JS error#470
OCA-git-bot merged 1 commit into
OCA:19.0from
ursais:19.0-fix-web_view_google_map-api-key-prompt

Conversation

@max3903

@max3903 max3903 commented Jul 31, 2026

Copy link
Copy Markdown
Member

Summary

  • Do not load the Google Maps JS API when the key is missing or the demo placeholder YOUR_GOOGLE_MAPS_API_KEY.
  • Show an Odoo empty-state with a Configure API key button (opens Settings) instead of Google's "Oops! Something went wrong" page.

Test plan

  • Install web_view_google_map with empty / placeholder google.api_key_geocode
  • Open Contacts (or any) Google Map view → see API key prompt, not Google JS error
  • Set a valid key in Settings → Google Maps View → map loads

Made with Cursor

@max3903 max3903 added this to the 19.0 milestone Jul 31, 2026
@max3903 max3903 self-assigned this Jul 31, 2026
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @wolfhall, @gityopie,
some modules you are maintaining are being modified, check this out!

@max3903 max3903 added the bug label Jul 31, 2026
@max3903

max3903 commented Aug 1, 2026

Copy link
Copy Markdown
Member Author

/ocabot merge patch

@OCA-git-bot

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 19.0-ocabot-merge-pr-470-by-max3903-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 410cbd6 into OCA:19.0 Aug 1, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 0358e64. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants