[14.0] helpdesk_mgmt: Forward port multiple 12.0 commits#448
[14.0] helpdesk_mgmt: Forward port multiple 12.0 commits#448
Conversation
ypapouin
force-pushed
the
14.0-fw-port-12.0
branch
from
3199f4c to
d4bfa67
Compare
|
when do we expect to merge these changes? |
| IrAttachment = request.env["ir.attachment"] | ||
| attachment_ids = IrAttachment |
There was a problem hiding this comment.
what's the point of this?
| IrAttachment = request.env["ir.attachment"] | |
| attachment_ids = IrAttachment | |
| attachment_ids = request.env["ir.attachment"] |
There was a problem hiding this comment.
IrAttachment is used in the create statement below, that's why the model is set once outside the loop
|
|
||
| def send_partner_mail(self): | ||
| created_ticket_template = self.env.ref( | ||
| "helpdesk_mgmt.created_ticket_template", raise_if_not_found=False |
There was a problem hiding this comment.
This template is missing
There was a problem hiding this comment.
Really want these changes merged.
There are some issues. For example the customer can add some attachments and see them, but there doesn't seem to be a way for the internal operator to upload attachments from the user view and show them for the customer in the portal view.
Also, I think the "created" email template should not be forcefully sent in the create method, but should be attached to the "new" state and work like every other email template.
That said, I'd rather this be merged and these issues fixes in future PRs, personally. The only thing that's blocking IMO is the missing email template for new tickets.
…mail Forward port of fcf0a41
…uttons on portal Forward port of 6eb1124 with minor fixes
…iew, also considering priority Forward port of fe7a9ef
- Better style - Avoid email_cc (error "message without recipients") - Use coherent partner/user reference - Access button from e-mail notifications Forward port of 98e5ef7 Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
Forward port of dfbc369
…d on ticket submit Otherwise they stay "private" and are not displayed on the portal.
…et stage has changed
ypapouin
force-pushed
the
14.0-fw-port-12.0
branch
from
d4bfa67 to
a56b0d8
Compare
|
@aleuffre, the missing template is re-added. About this, I tried to use the built-in way to send email notification on ticket creation by assigning About attachments, the chatter allows the internal users to add public attachments from the backend (using Also, please give me some time, I will try to increase code coverage before merging. |
- `portal_user_can_close` is now set to `done` and `cancelled` stages by default - `/ticket/close` has been replaced with `/close/ticket` to be consistent with other routes
|
Too much things in one PR. This should be split by each function to be discussed and reviewed isolatedly, or there are few chances of this being merged as is. |
|
@pedrobaeza, I understand your position but most of these commits are already merged in the 12.0 branch, its like a migration update, others one are tests. |
|
I use the module since 13.0, so I didn't take part on the decisions made on v12, so I'm still reluctant to approve this on batch. |
|
I also need these commits on v14. Will start opening some PRs separately if the whole thing won't be accepted. |
|
@pedrobaeza as your request, this PR has been split into multiple PRs. |
5 participants
See commits for details.
This is a pack multiple commits authored by @eLBati, fixed and rewritten to be compatible with Odoo 14.0.
portal_user_can_close.mail.mail_notification_lightlayout to have a consistent design.