Skip to content

[14.0][FW-PORT] helpdesk_mgmt: Simplify e-mail templates#467

Closed
ypapouin wants to merge 3 commits intoOCA:14.0from
decgroupe:14.0-fw-port-12.0-email-templates
Closed

[14.0][FW-PORT] helpdesk_mgmt: Simplify e-mail templates#467
ypapouin wants to merge 3 commits intoOCA:14.0from
decgroupe:14.0-fw-port-12.0-email-templates

Conversation

@ypapouin
Copy link
Copy Markdown
Contributor

This PR has been split from #448

  • E-mail templates are simplified, they now all use the mail.mail_notification_light layout to have a consistent design.
  • Send a notification to the partner each time the ticket stage changes.

Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also mixing several things. All related to mail templates, but too much extreme changes IMO.

@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from faeeb5c to 6150f6f Compare May 16, 2023 08:05
@ypapouin
Copy link
Copy Markdown
Contributor Author

The display_name is now used for all templates body.
I also edited the doc to explain the stage's email template.

@pedrobaeza pedrobaeza added this to the 14.0 milestone May 16, 2023
@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 17, 2023
@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from 19f6fa0 to a836c25 Compare October 11, 2023 13:55
Copy link
Copy Markdown

@renda-dev renda-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of quick and really small changes could be made but the code LGTM overall.

@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from a836c25 to ef33c7c Compare October 24, 2023 07:24
eLBati and others added 3 commits October 24, 2023 09:27
- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
@ypapouin ypapouin force-pushed the 14.0-fw-port-12.0-email-templates branch from ef33c7c to 1625ab7 Compare October 24, 2023 07:28
@github-actions github-actions bot closed this Nov 26, 2023
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Jan 9, 2024
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Jan 9, 2024
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Jan 9, 2024
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 8, 2024
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 8, 2024
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 8, 2024
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 23, 2024
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 23, 2024
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 23, 2024
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 24, 2024
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 24, 2024
renda-dev pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 24, 2024
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 29, 2024
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 29, 2024
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Apr 29, 2024
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Oct 14, 2024
…mplates

- Avoid email_cc (error "message without recipients")
- Use coherent partner/user reference
- Access button from e-mail notifications

Semi-forward port of 98e5ef7

Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Oct 14, 2024
PicchiSeba pushed a commit to PyTech-SRL/helpdesk that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants