[16.0][IMP]helpdesk_mgmt: simplify email templates#644
Closed
PicchiSeba wants to merge 3 commits intoOCA:16.0from
Closed
[16.0][IMP]helpdesk_mgmt: simplify email templates#644PicchiSeba wants to merge 3 commits intoOCA:16.0from
PicchiSeba wants to merge 3 commits intoOCA:16.0from
Conversation
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
2 times, most recently
from
71ce9a6 to
a582bc6
Compare
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
3 times, most recently
from
4628224 to
3761007
Compare
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
2 times, most recently
from
463cb24 to
8a1fc5e
Compare
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
from
8a1fc5e to
2852874
Compare
Author
|
I just rebased because of a conflict arising from the merge of #643 |
pedrobaeza
requested changes
Nov 26, 2024
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
There's an unrelated commit, and the fw-port seems done without checking.
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
2 times, most recently
from
bcad72d to
fc7d3f4
Compare
Author
|
I removed the unrelated commit, the new email template (will do another PR for that) and the Do you see any other critical issue? |
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
from
fc7d3f4 to
d0983db
Compare
HekkiMelody
suggested changes
Nov 26, 2024
Contributor
|
I see 3 different purposes to this PR
|
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
2 times, most recently
from
2bdd3e3 to
7c4cc4b
Compare
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
2 times, most recently
from
a513d1e to
fd8fba7
Compare
- Avoid email_cc (error "message without recipients") - Use coherent partner/user reference - Access button from e-mail notifications Semi-forward port of 98e5ef7 Please note that the commit a5041c2 (An e-mail is sent to the ticket after each create/edit) has not been forward ported because the assignment notify is done internally by odoo in `_message_auto_subscribe_followers` from `mail.thread`
Forward port of dfbc369
PicchiSeba
force-pushed
the
16.0-simplify-email-templates
branch
from
fd8fba7 to
60bfad7
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-ports #467 which itself partially forward-ported 98e5ef7 and dfbc369 from 12.0 to 14.0