[15.0][MIG] l10n_es_account_statement_import_n43 - #2070
Merged
OCA-git-bot merged 35 commits intoFeb 21, 2022
Merged
Conversation
…bank_statement para importar extractos bancarios N43
…on monedas distintas de euros segun issue OCA#217 y basado en comentario de @fgarciag2001
…baciones extra para obtener el partner extraídas del n43 de Bankia Y Sabadell
…ing other statement formats
Improvements ------------ * Counterpart account automatically detected from N43 type (deactivated for now) * Tests
…een 'fecha_valor' and 'fecha_oper'.
…tros 22, nº documento incorrecto
* Metafiles updated * Test adapted to Python 3 * Test coverage improved
…te_type With this, this is compatible with tests that creates journals before this module is loaded.
* Standard procedure * Override method for adding the supported format * README by fragments * Tests adapted for new date format and order
…tween type of exception raised adn type of exception catched
Currently translated at 100.0% (14 of 14 strings) Translation: l10n-spain-12.0/l10n-spain-12.0-l10n_es_account_bank_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-12-0/l10n-spain-12-0-l10n_es_account_bank_statement_import_n43/gl/
…compatibility with BBVA files (OCA#1056) Some statement files include BOM data (https://es.wikipedia.org/wiki/Marca_de_orden_de_bytes) at the beginning of the file, making them non readable by current parser, as fixed positions are moved in these cases and thus expected data is not matched. As ASCII, which is the encoding used in files according specification, is a subset of UTF-8, there's no danger in using it with the variant 'utf-8-sig' for handling if BOM marker is present or not.
…her encodings + flake8
…n tests with other statement import modules Journal in context should be available since the beginning, as it can be used in default get for example.
…ment as the start date
Currently translated at 100.0% (15 of 15 strings) Translation: l10n-spain-13.0/l10n-spain-13.0-l10n_es_account_bank_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-13-0/l10n-spain-13-0-l10n_es_account_bank_statement_import_n43/es/
…lient Other modules can add a partner called "Test partner", as the name is very generic, provoking an error in the test. We specify another name that don't collapse with other data for avoiding it.
…unt_bank_statement_import_n43 to v14
* If the journal has no currency defined, use the company one. * On v14, the name field is use for the account.move numbering, so it collapses with the expected sequence. The proper field is payment_ref.
Currently translated at 94.4% (17 of 18 strings) Translation: l10n-spain-14.0/l10n-spain-14.0-l10n_es_account_statement_import_n43 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-14-0/l10n-spain-14-0-l10n_es_account_statement_import_n43/es/
…ot conceptos There are some banks that doesn't populate any record 23 for specifying concepts, so we need to fallback to the references (although not very accurate) for avoiding the error as the payment_ref is required.
Bilbonet
force-pushed
the
15.0-mig-l10n_es_account_statement_import_n43
branch
from
February 1, 2022 13:10
0e8579c to
7f9d370
Compare
Bilbonet
changed the title
Contributor
|
/ocabot migration l10n_es_account_statement_import_n43 |
javidiez
approved these changes
Feb 21, 2022
javidiez
left a comment
javidiez
left a comment
There was a problem hiding this comment.
I have tried importing the statement in v15 and had no problem.
pedrobaeza
approved these changes
Feb 21, 2022
Member
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
This PR has the |
Contributor
|
Congratulations, your PR was merged at 657b675. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard migration