Skip to content

[18.0][FIX] mail_composer_cc_bcc: emails list - #54

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
norlinhenrik:18.0-fix-mail_mail-email_to
Sep 25, 2025
Merged

[18.0][FIX] mail_composer_cc_bcc: emails list#54
OCA-git-bot merged 1 commit into
OCA:18.0from
norlinhenrik:18.0-fix-mail_mail-email_to

Conversation

@norlinhenrik

@norlinhenrik norlinhenrik commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

image

mail.mail.email_to had comma between each character. Not so anymore.

image

@norlinhenrik
norlinhenrik force-pushed the 18.0-fix-mail_mail-email_to branch from 42bd42c to 73fc3d2 Compare June 15, 2025 19:55
@norlinhenrik

norlinhenrik commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

@trisdoan @pedrobaeza

Default behavior in mail is that _prepare_outgoing_list() returns mails with email_to as a LIST.

Currently, with mail_composer_cc_bcc _prepare_outgoing_list() returns email_to as a STRING. This also works somehow.

But mail_tracking converts email_to from LIST to STRING using COMMASPACE.

So email_to needs to be a list, to avoid the error described above.

@pedrobaeza

pedrobaeza commented Jun 25, 2025

Copy link
Copy Markdown
Member

I don't use this module, sorry.

@trisdoan

trisdoan commented Jun 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Hello @norlinhenrik, you are right, thanks for the fix, but CI is red, could you take a look please?

Also, I got error: Invalid email address
2025-06-25_17-28

@norlinhenrik
norlinhenrik force-pushed the 18.0-fix-mail_mail-email_to branch from 73fc3d2 to 1415ef6 Compare June 25, 2025 15:47
@norlinhenrik

norlinhenrik commented Jun 25, 2025

Copy link
Copy Markdown
Contributor Author

I have no idea why a test is failing here. It passes locally.
image

@trisdoan trisdoan mentioned this pull request Jun 26, 2025
Closed
trisdoan
trisdoan suggested changes Jul 4, 2025
View reviewed changes
Comment thread mail_composer_cc_bcc/tests/test_mail_cc_bcc.py Outdated
@BT-anieto

BT-anieto commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

@norlinhenrik Is there any advancements here?

@norlinhenrik

norlinhenrik commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

@trisdoan @BT-anieto
Can you please test this PR, and approve it if it works as expected?
I believe it is ready to merge.

@norlinhenrik
norlinhenrik marked this pull request as draft September 9, 2025 10:15
@norlinhenrik
norlinhenrik force-pushed the 18.0-fix-mail_mail-email_to branch from 1415ef6 to a8b36c7 Compare September 9, 2025 11:26
@norlinhenrik
[FIX] mail_composer_cc_bcc: emails list
7932bde 
Default behavior in ´mail´ is that
_prepare_outgoing_list() returns mails with email_to as a LIST.

´mail_tracking´ is dependent on this behvaior,
and it converts LIST to STRING using COMMASPACE.

Without the fix in this commit,
the combination of ´mail_composer_cc_bcc´ and ´mail_tracking´
will produce email_to with comma between each character.
@norlinhenrik
norlinhenrik force-pushed the 18.0-fix-mail_mail-email_to branch from a8b36c7 to 7932bde Compare September 9, 2025 11:50
@norlinhenrik
norlinhenrik marked this pull request as ready for review September 9, 2025 11:55
@norlinhenrik

norlinhenrik commented Sep 9, 2025

Copy link
Copy Markdown
Contributor Author

@trisdoan @BT-anieto
Finally the tests are passing.
Can you please review?

ChristophAbenthungCibex
ChristophAbenthungCibex approved these changes Sep 23, 2025
View reviewed changes

@ChristophAbenthungCibex ChristophAbenthungCibex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@OCA-git-bot

OCA-git-bot commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@trisdoan

trisdoan commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-54-by-trisdoan-bump-patch, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit e6d9a41 into OCA:18.0 Sep 25, 2025
9 checks passed
@OCA-git-bot

OCA-git-bot commented Sep 25, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at d93d6d0. Thanks a lot for contributing to OCA. ❤️

@luciaavanzosc luciaavanzosc mentioned this pull request Oct 9, 2025
Closed
@trisdoan trisdoan mentioned this pull request Aug 17, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@trisdoan trisdoan trisdoan approved these changes
@ChristophAbenthungCibex ChristophAbenthungCibex ChristophAbenthungCibex approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@norlinhenrik @pedrobaeza @trisdoan @BT-anieto @OCA-git-bot @ChristophAbenthungCibex