[19.0][MIG] repair_refurbish - #181
Open
JasminSForgeFlow wants to merge 53 commits into
Open
Conversation
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: manufacture-12.0/manufacture-12.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/manufacture-12-0/manufacture-12-0-repair_refurbish/
…en if there is a refurbish product
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: repair-16.0/repair-16.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/repair-16-0/repair-16-0-repair_refurbish/
Currently translated at 100.0% (16 of 16 strings) Translation: repair-16.0/repair-16.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/repair-16-0/repair-16-0-repair_refurbish/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: repair-17.0/repair-17.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/repair-17-0/repair-17-0-repair_refurbish/
Currently translated at 100.0% (16 of 16 strings) Translation: repair-17.0/repair-17.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/repair-17-0/repair-17-0-repair_refurbish/it/
The design of this module was really faulty in new v17. A small refactor here helps to make the module useful again.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: repair-17.0/repair-17.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/repair-17-0/repair-17-0-repair_refurbish/
Currently translated at 100.0% (16 of 16 strings) Translation: repair-17.0/repair-17.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/repair-17-0/repair-17-0-repair_refurbish/it/
Currently translated at 100.0% (16 of 16 strings) Translation: repair-17.0/repair-17.0-repair_refurbish Translate-URL: https://translation.odoo-community.org/projects/repair-17-0/repair-17-0-repair_refurbish/it/
BhaveshHeliconia
approved these changes
Aug 25, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
Contributor
There was a problem hiding this comment.
Code review LGTM!
Contributor
|
@JasminSForgeFlow could you please squash the administrative and bot commits? |
AaronHForgeFlow
left a comment
AaronHForgeFlow
left a comment
Contributor
There was a problem hiding this comment.
Functional + code LG, just minor comment.
| products = self.env["product.product"].search( | ||
| [("refurbish_product_id", operator, value)], limit=None | ||
| ) | ||
| return [("id", "in", products.mapped("product_tmpl_id").ids)] |
Contributor
There was a problem hiding this comment.
Suggested change
| return [("id", "in", products.mapped("product_tmpl_id").ids)] | |
| return Domain([("id", "in", products.product_tmpl_id.ids)]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard Migration
@ForgeFlow