Replicate specification of Object extension section - #607
Merged
Conversation
rosy1280
requested review from
julianmorley,
neilsjefferies,
rosy1280 and
zimeon
June 22, 2022 16:59
rosy1280
reviewed
Jun 22, 2022
| the purposes of extending the functionality of an OCFL Storage Root. The guidelines and limitations for the storage | ||
| root `extensions` directory are defined in alignment with those of the [object extensions](#object-extensions). | ||
|
|
||
| The `extensions` directory <span id="E112" class="rfc2119">MUST NOT</span> contain any files, and no sub-directories |
Contributor
There was a problem hiding this comment.
This sentence is awkward. Why not:
The
extensionsdirectory MUST NOT contain any files or subdirectories other than extension subdirectories...
zimeon
requested changes
Jun 22, 2022
| other than extension sub-directories. Extension sub-directories <span id="W016" class="rfc2119">SHOULD</span> be named | ||
| according to a <a>registered extension name</a>. | ||
|
|
||
| > Non-normative note: Extension sub-directories should use the same name as a registered extension in order to both |
Contributor
There was a problem hiding this comment.
Can we run the two non-normative notes (this and the existing one that follows) into one? I.e. put a > for the blank line between paras and remove the second "Non-normative note: "
zimeon
approved these changes
Jun 22, 2022
neilsjefferies
approved these changes
Jun 22, 2022
julianmorley
approved these changes
Jun 23, 2022
rosy1280
added a commit
that referenced
this pull request
Jun 23, 2022
changes this to match other language changes in PR #607
julianmorley
pushed a commit
that referenced
this pull request
Jun 24, 2022
changes this to match other language changes in PR #607
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update replicates the Object extension specification text from Object extension into Storage Root extension
Resolves: #557
Supersedes: #583