Switch tests to use Testcontainers instead of postgres database#494
Merged
alex-odysseus merged 1 commit intodevelopfrom Nov 5, 2021
Merged
Switch tests to use Testcontainers instead of postgres database#494alex-odysseus merged 1 commit intodevelopfrom
alex-odysseus merged 1 commit intodevelopfrom
Conversation
alex-odysseus
suggested changes
Nov 4, 2021
| import org.testcontainers.shaded.com.google.common.collect.ImmutableMap; | ||
|
|
||
| public class TestContainersInitializer implements ApplicationContextInitializer<ConfigurableApplicationContext> { | ||
| static PostgreSQLContainer<?> postgres = new PostgreSQLContainer<>(); |
Contributor
There was a problem hiding this comment.
'postgre' or 'postgreSql', please
| <dependency> | ||
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>testcontainers</artifactId> | ||
| <version>1.16.0</version> |
Contributor
There was a problem hiding this comment.
Any arguments not to use the latest version 1.16.2?
Contributor
There was a problem hiding this comment.
To be addressed in the future
alex-odysseus
approved these changes
Nov 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, java-docker is upgraded 3.2.7 -> 3.2.11 as the latter is required for testcontainers.