CohortGeneration job left in 'STARTED' state when error is thrown.

[chrisknoll]

Expected behavior

If there is a failure during cohort generation, the job should result in FAILED.

Actual behavior

The exception thrown in GenerationJobExecutionListener is ignored by Spring Batch.

Steps to reproduce behavior

This is difficult to reproduce because you need to throw an exception during GenerationJobExecutionListener.findBySourceId.
However, the behavior is described here.

The solution is to wrap the work done in afterJob (which contains the call to findBySourceId) in an exception handler such that the job step is set to failed:

Example code:

public class YourListener implements StepExecutionListener {

    @Override
    public ExitStatus afterStep(StepExecution stepExecution) {
        try {
            yourcode ///////
        } catch (Exception e) {

            //log your error 
            stepExecution.setStatus(BatchStatus.FAILED);
            stepExecution.addFailureException(e);
            return ExistStatus.FAILED.addDescription(e);
        }
        return ExitStatus.COMPLETED;
    }
}

[chrisknoll]

Note, the article I found talks about exception in afterStep() but in our case, we have an issue with afterJob (and beforeJob). This code should work:

public void afterJob(JobExecution jobExecution) {

    String message = "Completed  job.";

    try {
        //get context and batch
        ExecutionContext executionContext = jobExecution.getExecutionContext();
        //processing done here
    } catch (Exception coe) {
        jobExecution.addFailureException(coe);
        jobExecution.setExitStatus(new ExitStatus("FAILED", "Could not complete job"));
        jobExecution.setStatus(BatchStatus.FAILED);
        message = jobExecution.getExitStatus().getExitDescription();
    } finally {
        try {
            //Database update here. When this fails, the Job is expected be marked FAILED, but its marked COMPLETED
            throw new Exception("DB update failed"); //simulating exception
        } catch (Exception e) {
            System.out.println("Exception while saving final details to DB. This is printed");
            jobExecution.addFailureException(e);
            jobExecution.setExitStatus(new ExitStatus("FAILED", "Could not complete job"));
            jobExecution.setStatus(BatchStatus.FAILED);
        }
    }

}