Added 'dataset' parameter to bigquery #1121
Merged
Conversation
pavgra
reviewed
May 23, 2019
| } | ||
| final String translatedSql = SqlTranslate.translateSql(sql, source.getSourceDialect()); | ||
| final String translatedSql; | ||
| if (DBMSType.BIGQUERY.getOhdsiDB().equals(source.getSourceDialect())){ |
Contributor
There was a problem hiding this comment.
Having if doesn't look like a solid solution. Cannot we avoid it?
pavgra
approved these changes
May 28, 2019
anthonysena
pushed a commit
that referenced
this pull request
May 30, 2019
* added migration for Cohort Expression update (#1103) * Adds source password masquerading (#1112) * Fixes Sql injection vulnerability (#1102) * fixes pathway results migration (#1128) * Fixes CC generation using BigQuery (#1121) * Added caching for data density (#1138) * Heracles treemap drill-down reports are shown now (#1139) * Fixes inability to remove IR generation results for user having access to the Source (#1131) * Fixes DataSourceAccess security annotation (#1133) * Fixes DataSourceAccess security annotation * Fixes after review * Prepare files required for PLP Viewer shiny app in PLP script (#1142) * Fixes IR execution on non-accessible IRs (#1124) * Unique names for repeatedly added entities (#1145) * Build JAR file additionally to WAR (#1136) * Version increment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1108