Added postfix for repeatedly added Cohort Definition & Concept Set#1122
Closed
aklochkova wants to merge 6 commits intomasterfrom
Closed
Added postfix for repeatedly added Cohort Definition & Concept Set#1122aklochkova wants to merge 6 commits intomasterfrom
aklochkova wants to merge 6 commits intomasterfrom
Conversation
…mport-plp-ple-cc-pw # Conflicts: # src/main/java/org/ohdsi/webapi/db/migartion/V2_8_0_20190520171430__cohortExpressionHashCode.java
pavgra
suggested changes
May 24, 2019
Contributor
pavgra
left a comment
pavgra
left a comment
There was a problem hiding this comment.
What about regular copy methods?
pavgra
suggested changes
May 29, 2019
|
|
||
| public static String getNameWithSuffix(String dtoName, Function<String, Integer> countLikeName){ | ||
| while (countLikeName.apply(dtoName) > 0){ | ||
| dtoName = dtoName + " (" + countLikeName.apply(dtoName) + ")"; |
Contributor
There was a problem hiding this comment.
Why do you query database twice?
|
|
||
| public static String getNameForCopy(String dtoName, Function<String, Integer> countLikeName, Optional<?> existingObject) { | ||
| String nameWithPrefix = String.format(ENTITY_COPY_PREFIX, dtoName); | ||
| int similar = countLikeName.apply(nameWithPrefix); |
Contributor
There was a problem hiding this comment.
Why do you duplicate logic and do not re-use getNameWithSuffix?
| } | ||
|
|
||
| @GET | ||
| @Path("/{id}/copyName") |
Contributor
There was a problem hiding this comment.
Standard practice for URL names is to use hyphens
pavgra
suggested changes
May 29, 2019
| } | ||
|
|
||
| public static String getNameWithSuffix(String dtoName, Function<String, Integer> countLikeName){ | ||
| while (countLikeName.apply(dtoName) > 0){ |
Contributor
|
Test:
Expected result: Actual result: |
Contributor
|
Test:
Expected result: Actual result: |
Contributor
|
Closed in favor of #1145 which resolves all the issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100