Fixes failed AD group import #1162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml # src/main/java/org/ohdsi/webapi/cohortcharacterization/GenerateCohortCharacterizationTasklet.java # src/main/resources/resources/cohortcharacterizations/sql/prevalenceWithCriteria.sql
# Conflicts: # src/main/java/org/ohdsi/webapi/cohortcharacterization/CcServiceImpl.java
# Conflicts: # src/main/java/org/ohdsi/webapi/cohortcharacterization/GenerateCohortCharacterizationTasklet.java
# Conflicts: # src/main/java/org/ohdsi/webapi/service/FeatureExtractionService.java
pavgra
previously requested changes
Jun 5, 2019
Contributor
pavgra
left a comment
pavgra
left a comment
There was a problem hiding this comment.
As discussed with @anthonysena and @chrisknoll , let's store AD import properties in a separate table as we do this for CC, Pathways, etc
anthonysena
requested changes
Dec 18, 2019
...ces/db/migration/postgresql/V2.8.0.20190531181956__alter_job-execution-params_string-val.sql
Outdated
Show resolved
Hide resolved
anthonysena
approved these changes
Dec 24, 2019
anthonysena
dismissed
pavgra’s stale review
The changes made in this PR set a new column user_roles in the user_import_job table to store the roles from active directory which addresses the original review from @pavgra.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1155