SmartScrollbar component to show cached slices - #4340
SmartScrollbar component to show cached slices#4340Adithyan-Dinesh-Trenser wants to merge 1 commit into
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev canceled.
|
|
Cc : @Ouwen |
|
@sedghi is this something that could be in upstream? |
|
@Ouwen Hey guys, thanks, yes it can be. CCing our designer for this |
|
Hi everyone! I work as a UX designer on the OHIF team. This is amazing! Thank you for sharing! We would love to add this to OHIF. We are currently looking at some design updates that we'll want to apply here. I can take a look at those applied to this component at the end of this week (or early next) and share them here. Thank you again! ❤️ |
|
Hi there, thanks for this nice addition, I have a question about this statement The SmartScrollbar is only available in stack viewport as the number of imagesIds and the number of slices may vary in 2d MPR viewports. I wonder if it woundn't be possible to see things differently, rather then trying to mach the number of slice in the viewport consider the displayset loaded fraction. The displayset has a known number of frames so it would be possible to display how many slice of the display set have been loaded and this could work for a volume viewport no matter of its orientation. Maybe would need a bit different presentation. Could this PR be extended to another overlay maybe a progress circle to show the fraction of laoaded display set in case of a volume viewport ? |
d781297 to
5fa622b
Compare
…layset and added an extra feature to prevent scrolling to uncached slices.
5fa622b to
b2e4b28
Compare
|
We were too busy with the rest of the component library, and still didn't have time to look at the design here, sorry about the delay |
|
We're sorry we couldn't include this in 3.9 due to other high priorities. We appreciate your patience and will review this, and give a design as soon as possible. |
|
There isn't any reason that the same display can't be used for volumes - it is just as interesting there to know how much of the volume has gotten loaded. |
|
When we revisit this, we should consider adding a visual state to show whether a reader has viewed a slice. Some PACS already have this feature, preventing users from submitting a report until they have scrolled through every slice. Because of that, including a visual indicator in this component is really necessary. |
|
Everyone on this PR a big thank you. We have an open PR #5960 that is solidifying all your efforts and ideas from here. |
Context
A Viewport scrollbar that shows the cached slices of the displayset loading in that viewport. Also, a feature was added to scroll only to the cached slices in normal scrolling operations. To force scrolling ( scrolling to uncached slices ) must press the Ctrl key when scrolling.
Changes & Results
A sample screenshot of the SmartScrollbar
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment