Skip to content

wip-feat(renderingEngine): per viewport rendering engine flag - #4976

Closed
IbrahimCSAE wants to merge 4 commits into
masterfrom
feat/multi-render-engine
Closed

wip-feat(renderingEngine): per viewport rendering engine flag#4976
IbrahimCSAE wants to merge 4 commits into
masterfrom
feat/multi-render-engine

Conversation

@IbrahimCSAE

@IbrahimCSAE IbrahimCSAE commented Apr 19, 2025

Copy link
Copy Markdown
Member

issues:

  • cornerstone3D tools that assume a single rendering engine, like some synchronizers, reference lines tool etc
  • max webgl active contexts is 16, so 16 viewports only
  • volume viewports need to share the same engine

@netlify

netlify Bot commented Apr 19, 2025

Copy link
Copy Markdown

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit b7a4b27
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/68066e4837721f0008c4eddd

@cypress

cypress Bot commented Apr 19, 2025

Copy link
Copy Markdown

Viewers    Run #5159

Run Properties:  status check failed Failed #5159  •  git commit b7a4b271f5: fix
Project Viewers
Branch Review feat/multi-render-engine
Run status status check failed Failed #5159
Run duration 02m 38s
Commit git commit b7a4b271f5: fix
Committer Ibrahim
View all properties for this run ↗︎

Test results
Tests that failed  Failures 11
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 14
Tests that passed  Passing 13
View all changes introduced in this branch ↗︎

Tests for review

Failed  customization/HangingProtocol.spec.js • 2 failed tests

View Output Video

Test Artifacts
OHIF HP > Should navigate next/previous stage Test Replay Screenshots Video
OHIF HP > Should navigate to display set specified Test Replay Screenshots Video
Failed  measurement-tracking/OHIFCornerstoneToolbar.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed Test Replay Screenshots Video
Failed  measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed Test Replay Screenshots Video
Failed  measurement-tracking/OHIFStudyBrowser.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study Browser > checks if series thumbnails are being displayed Test Replay Screenshots Video
Failed  measurement-tracking/OHIFCornerstoneHotkeys.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Hotkeys > checks if hotkeys "R" and "L" can rotate the image Test Replay Screenshots Video

The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.

@IbrahimCSAE IbrahimCSAE changed the title feat(renderingEngine): per viewport rendering engine flag wip-feat(renderingEngine): per viewport rendering engine flag Apr 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant