fix(security): Use a resolution for axios to address CVE-2026-25639. - #5793
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Additional Comments (1)
This security PR is described as “bump axios + use a resolution”, but |
sedghi
left a comment
There was a problem hiding this comment.
we shouldn't really require axios, can we replace it with native fetch? This will reduce all the axios noise long term
Even if we replace it for our cli, there is still a few transitive dependencies for it. For example, itk-wasm depends on it. So it really doesn't help here. |
Context
GHSA-43fc-jf86-j433
Changes & Results
Bumped the version of axios and used a resolution.
Testing
Run automated tests.
Check segmentation interploation.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 7.25 GB / 31.68 GB
Binaries:
Node: 20.9.0 - C:\Users\joebo\AppData\Local\fnm_multishells\29608_1770221529011\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 10.1.0 - C:\Users\joebo\AppData\Local\fnm_multishells\29608_1770221529011\npm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 144.0.7559.110
Greptile Overview
Greptile Summary
Updates axios to
1.13.5to address GHSA-43fc-jf86-j433, enforcing the version across the Yarn v1 workspace via a root-levelresolutionsentry and updatingyarn.lock. The CLI workspace package (platform/cli) is also updated to match.One notable impact is that
bun.locknow includes broad workspace version bumps (e.g.,3.12.0-beta.133→3.13.0-beta.0) in addition to the axios change, which expands the PR’s scope beyond the stated security fix.Confidence Score: 3/5
Important Files Changed
resolutionsentry to force that version across the workspace; no code logic changes.configVersion, bumps many internal workspace package versions to 3.13.0-beta.0, and updates axios to 1.13.5 in overrides; scope looks broader than the stated axios-only security fix and should be confirmed intentional.Sequence Diagram
(5/5) You can turn off certain types of comments like style here!