revert: rename DisplaySet.frameOfReferenceUID back to FrameOfReferenceUID

[GhadeerAlbattarni]

Summary

• Reverts the frameOfReferenceUID property on the DisplaySet type back to FrameOfReferenceUID

Context

A previous PR #5900 renamed FrameOfReferenceUID → frameOfReferenceUID on the DisplaySet type. This PR reverts that specific change.

Files Changed

• platform/core/src/types/DisplaySet.ts
• extensions/default/src/getSopClassHandlerModule.js
• extensions/cornerstone/src/getSopClassHandlerModule.js
• extensions/cornerstone/src/components/ViewportDataOverlaySettingMenu/utils.ts
• extensions/cornerstone-dicom-seg/src/getSopClassHandlerModule.ts
• extensions/cornerstone-dicom-rt/src/getSopClassHandlerModule.ts
• extensions/cornerstone-dicom-sr/src/getSopClassHandlerModule.ts
• extensions/cornerstone-dicom-sr/src/utils/hydrateStructuredReport.ts
• extensions/dicom-microscopy/src/services/MicroscopyService.ts
• extensions/dicom-microscopy/src/utils/getSourceDisplaySet.js

Testing

Checklist

PR

• [] My Pull Request title is descriptive, accurate and follows the
  semantic-release format and guidelines.

Code

• [] My code has been well-documented (function documentation, inline comments,
  etc.)

Public Documentation Updates

• [] The documentation page has been updated as necessary for any public API
  additions or removals.

Tested Environment

• [] OS:
• [] Node version:
• [] Browser:

Greptile Summary

This PR reverts the rename introduced in PR #5900, restoring DisplaySet.FrameOfReferenceUID (PascalCase) across the type definition and all call sites. The change is consistent with the DICOM-standard casing used throughout the rest of the codebase.

All 10 explicitly listed files are updated correctly. However, one call site was missed:

• extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts lines 1336\u20131337 \u2014 _getFrameOfReferenceUID still reads displaySet.frameOfReferenceUID (old lowercase name). The property will always be undefined, causing the function to skip the early-return and rely on the images[0].FrameOfReferenceUID fallback. For display sets without an images array the function silently returns undefined, breaking Frame-of-Reference resolution for those display sets.

Confidence Score: 4/5

Not safe to merge as-is — one missed call site in CornerstoneViewportService will silently return undefined for image-less display sets.

Score of 4 reflects a single real P1 defect: a missed property rename in CornerstoneViewportService that causes _getFrameOfReferenceUID to skip its primary return path and rely on a fallback that fails for image-less display sets.

extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts (lines 1336-1337)

Important Files Changed

Filename	Overview
platform/core/src/types/DisplaySet.ts	Type definition updated: frameOfReferenceUID → FrameOfReferenceUID. Straightforward and correct.
extensions/default/src/getSopClassHandlerModule.js	Display-set construction updated to use FrameOfReferenceUID as the property key.
extensions/cornerstone/src/getSopClassHandlerModule.js	Shorthand property renamed from frameOfReferenceUID: FrameOfReferenceUID to FrameOfReferenceUID.
extensions/cornerstone/src/components/ViewportDataOverlaySettingMenu/utils.ts	Frame-of-reference comparison updated to FrameOfReferenceUID; separate segmentation.frameOfReferenceUID usage at line 162 is on a segmentation service object, not a DisplaySet, so it is unrelated.
extensions/cornerstone-dicom-seg/src/getSopClassHandlerModule.ts	SEG display-set construction and deferred update both correctly switched to FrameOfReferenceUID.
extensions/cornerstone-dicom-rt/src/getSopClassHandlerModule.ts	RTSTRUCT display-set construction and two assignment paths all updated to FrameOfReferenceUID.
extensions/cornerstone-dicom-sr/src/getSopClassHandlerModule.ts	_measurementBelongsToDisplaySet predicate updated to compare against displaySet.FrameOfReferenceUID.
extensions/cornerstone-dicom-sr/src/utils/hydrateStructuredReport.ts	Both getDisplaySetsBy filter callbacks updated to use FrameOfReferenceUID.
extensions/dicom-microscopy/src/services/MicroscopyService.ts	Destructuring and filter conditions updated to FrameOfReferenceUID.
extensions/dicom-microscopy/src/utils/getSourceDisplaySet.js	Display-set find predicate updated to FrameOfReferenceUID.

Comments Outside Diff (2)

1. extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts, line 1336-1337 (link)

   Missed rename causes silent undefined return

   _getFrameOfReferenceUID still accesses displaySet.frameOfReferenceUID (lowercase), but this PR renames that property to FrameOfReferenceUID on the DisplaySet type. JavaScript property access is case-sensitive, so displaySet.frameOfReferenceUID will always be undefined after this change. The function will silently fall through to the SEG/RTSTRUCT/images fallbacks — meaning regular display sets (e.g., those created by the default or cornerstone SOP class handlers that set FrameOfReferenceUID) will never have their frame of reference UID correctly returned by this method, potentially breaking viewport synchronization and any feature that relies on matching display sets by frame of reference.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
   Line: 1336-1337
   
   Comment:
   **Missed rename causes silent `undefined` return**
   
   `_getFrameOfReferenceUID` still accesses `displaySet.frameOfReferenceUID` (lowercase), but this PR renames that property to `FrameOfReferenceUID` on the `DisplaySet` type. JavaScript property access is case-sensitive, so `displaySet.frameOfReferenceUID` will always be `undefined` after this change. The function will silently fall through to the `SEG`/`RTSTRUCT`/`images` fallbacks — meaning regular display sets (e.g., those created by the default or cornerstone SOP class handlers that set `FrameOfReferenceUID`) will never have their frame of reference UID correctly returned by this method, potentially breaking viewport synchronization and any feature that relies on matching display sets by frame of reference.
   
   
   
   How can I resolve this? If you propose a fix, please make it concise.

2. extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts, line 1336-1337 (link)

   Missed revert: still reads old frameOfReferenceUID property

   This function reads displaySet.frameOfReferenceUID (lowercase), but after this revert PR the canonical property is FrameOfReferenceUID (uppercase). The check on line 1336 will always evaluate to false/undefined for every display set, silently bypassing the intended early-return path and falling through to the images[0].FrameOfReferenceUID fallback.

   For display sets that have images, the fallback still returns the correct value, so the regression is subtle. However, for display sets that reach this function and have no images array (or an empty one), the function returns undefined instead of the correct Frame of Reference UID — breaking viewport registration for those cases.

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
   Line: 1336-1337
   
   Comment:
   **Missed revert: still reads old `frameOfReferenceUID` property**
   
   This function reads `displaySet.frameOfReferenceUID` (lowercase), but after this revert PR the canonical property is `FrameOfReferenceUID` (uppercase). The check on line 1336 will always evaluate to `false`/`undefined` for every display set, silently bypassing the intended early-return path and falling through to the `images[0].FrameOfReferenceUID` fallback.
   
   For display sets that have `images`, the fallback still returns the correct value, so the regression is subtle. However, for display sets that reach this function and have no `images` array (or an empty one), the function returns `undefined` instead of the correct Frame of Reference UID — breaking viewport registration for those cases.
   
   
   
   How can I resolve this? If you propose a fix, please make it concise.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: extensions/cornerstone/src/services/ViewportService/CornerstoneViewportService.ts
Line: 1336-1337

Comment:
**Missed revert: still reads old `frameOfReferenceUID` property**

This function reads `displaySet.frameOfReferenceUID` (lowercase), but after this revert PR the canonical property is `FrameOfReferenceUID` (uppercase). The check on line 1336 will always evaluate to `false`/`undefined` for every display set, silently bypassing the intended early-return path and falling through to the `images[0].FrameOfReferenceUID` fallback.

For display sets that have `images`, the fallback still returns the correct value, so the regression is subtle. However, for display sets that reach this function and have no `images` array (or an empty one), the function returns `undefined` instead of the correct Frame of Reference UID — breaking viewport registration for those cases.

```suggestion
    if (displaySet.FrameOfReferenceUID) {
      return displaySet.FrameOfReferenceUID;
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (2): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile}

[netlify]

✅ Deploy Preview for ohif-dev ready!

Name	Link
🔨 Latest commit	66b0ffb
🔍 Latest deploy log	https://app.netlify.com/projects/ohif-dev/deploys/69d3c21cad737b0008e4413f
😎 Deploy Preview	https://deploy-preview-5943--ohif-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.