fix: Release deploy of docs - #6095
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Netlify deployment step in the docs build GitHub Actions workflow is updated to deploy using an absolute repo-root path ( ChangesNetlify Docs Deploy Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/netlify-deploy-directory
|
| Run status |
|
| Run duration | 01m 43s |
| Commit |
|
| Committer | Bill Wallace |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
0
|
|
|
28
|
| View all changes introduced in this branch ↗︎ | |
No functional change, just deploy the docs in the newer pnpm world
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Summary by CodeRabbit
Greptile Summary
This PR fixes the docs deployment step in the GitHub Actions workflow to work correctly in the pnpm monorepo. The old approach
cd-ed intoplatform/docsbefore invokingnetlify-cli, but without--no-buildthe CLI would still attempt to run its own build using the repo-rootnetlify.toml(which targets the main viewer app, not the docs).--no-buildso netlify-cli deploys the already-built output without triggering a second build, and--diris updated to the repo-root-relative pathplatform/docs/buildto match the new working directory assumption.Confidence Score: 5/5
Safe to merge — the change is a targeted, well-explained one-liner fix with no functional side-effects on the rest of the workflow.
The only touched file is the docs deploy step of a GitHub Actions workflow. The fix is minimal and correct: it prevents netlify-cli from running a redundant (and wrong) build by adding
--no-build, and adjusts the--dirpath to be repo-root-relative to match the new invocation context. Secrets remain properly sourced from environment variables, and the rest of the workflow is untouched.No files require special attention.
Important Files Changed
cd + npx netlify-cli deployinvocation with a single-line deploy using--no-buildand a repo-root-relative--dir, preventing netlify-cli from re-running the wrong build via the rootnetlify.toml.Reviews (1): Last reviewed commit: "fix: Release deploy of docs" | Re-trigger Greptile