fix(crosshairs): keep Crosshairs active alongside brush/zoom/pan in MPR - #6157
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughCrosshairs tool configurations in preclinical 4D, segmentation MPR, and ultrasound annotation MPR tool groups now require Primary mouse input with Shift. ChangesCrosshairs bindings
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@platform/app/src/routes/WorkList/WorkList.tsx`:
- Around line 147-155: Update the comment above manualFiltering in the WorkList
table configuration to state that the table must not re-filter client-side
because filtering is performed upstream. Keep the existing
manualFiltering={true} behavior unchanged and correct only the contradictory
wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1caed471-be01-4752-938c-b50dd58da449
📒 Files selected for processing (4)
modes/preclinical-4d/src/initToolGroups.tsxmodes/segmentation/src/initToolGroups.tsmodes/usAnnotation/src/initToolGroups.jsplatform/app/src/routes/WorkList/WorkList.tsx
Viewers
 |
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/worklist-search-and-mpr-crosshairs
|
| Run status |
|
| Run duration | 01m 46s |
| Commit |
|
| Committer | Alireza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
0
|
 |
0
|
 |
28
|
| View all changes introduced in this branch ↗︎ | |
jbocce
requested changes
Jul 17, 2026
In the segmentation, usAnnotation and preclinical-4d modes the MPR Crosshairs tool was configured with no mouse binding and disableOnPassive: true. Without a binding it activates on plain Primary, so the moment another Primary tool in the same `mpr` group (brush, zoom, pan) is activated from the toolbar, the setToolActive handler evicts Crosshairs and — because of disableOnPassive — fully disables it, making them mutually exclusive. Measurement tools were unaffected only because they are not members of the `mpr` group. Bind Crosshairs to Primary+Shift (matching the longitudinal/tmtv modes) so it lives on its own binding and stays active alongside brush/zoom/pan. Fixes #6152
sedghi
force-pushed
the
fix/worklist-search-and-mpr-crosshairs
branch
from
July 17, 2026 15:52
61f4df7 to
782cb3a
Compare
sedghi
changed the title
sedghi
changed the title
Member
Author
|
@jbocce i made it crosshair only |
Collaborator
|
I just tried the deploy preview and this is still broken. ScreenHunter.Jul.17.18.01.mp4 |
jbocce
approved these changes
Jul 17, 2026
dchansen06
pushed a commit
to iCRcompany/OHIFViewer
that referenced
this pull request
Jul 27, 2026
…PR (OHIF#6157) In the segmentation, usAnnotation and preclinical-4d modes the MPR Crosshairs tool was configured with no mouse binding and disableOnPassive: true. Without a binding it activates on plain Primary, so the moment another Primary tool in the same `mpr` group (brush, zoom, pan) is activated from the toolbar, the setToolActive handler evicts Crosshairs and — because of disableOnPassive — fully disables it, making them mutually exclusive. Measurement tools were unaffected only because they are not members of the `mpr` group. Bind Crosshairs to Primary+Shift (matching the longitudinal/tmtv modes) so it lives on its own binding and stays active alongside brush/zoom/pan. Fixes OHIF#6152
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6152.
Problem
In the
segmentation,usAnnotation, andpreclinical-4dmodes, the MPR Crosshairs tool was configured with no mouse binding anddisableOnPassive: true. Without a binding it activates on plain Primary, so activating another Primary tool in the samemprtool group (brush, zoom, pan) makessetToolActiveevict Crosshairs and — because ofdisableOnPassive— fully disable it. The two tools therefore can't be active at the same time. Measurement tools were unaffected only because they aren't members of themprgroup.Fix
Bind Crosshairs to Primary + Shift (matching the
longitudinal/tmtvmodes) so it lives on its own mouse binding and stays active alongside brush/zoom/pan. Three modeinitToolGroupsfiles, +34 lines.Testing
Open a study in segmentation mode → MPR → enable Crosshairs → activate the brush (then zoom, then pan): Crosshairs stays active (Shift+drag to move it), and toggling between them no longer disables the other.