Skip to content

fix(cornerstone): bump cornerstone3D to 5.6.7 - #6161

Merged
sedghi merged 2 commits into
masterfrom
chore/bump-cornerstone-5.6.7
Jul 17, 2026
Merged

fix(cornerstone): bump cornerstone3D to 5.6.7#6161
sedghi merged 2 commits into
masterfrom
chore/bump-cornerstone-5.6.7

Conversation

@sedghi

@sedghi sedghi commented Jul 17, 2026

Copy link
Copy Markdown
Member

Bumps all @cornerstonejs/* packages from 5.6.4 to 5.6.7.

Fixes pulled in

  • 5.6.7 — cornerstone3D#2816: load co-planar DICOM SEGs whose ImageOrientationPatient is delivered as DICOM DS strings. Previously a SEG that was perfectly in-plane with its source (common with DICOMweb sources such as Orthanc) was rejected with "Segmentations orthogonal to the acquisition plane of the source data are not yet supported." — the adapter's orientation check compared string IOP against numeric source cosines with a type-strict equality.
  • 5.6.6 — cornerstone3D#2814: re-apply invert after a colormap is applied when scrolling a stack. Fixes Invert being lost on scroll after a Reset ([Bug] After a reset, Invert is lost when scrolling between slices #6153).
  • 5.6.5: pin websocket-driver to 0.7.5.

Changes

  • @cornerstonejs/* (core, tools, adapters, ai, metadata, dicom-image-loader, labelmap-interpolation, polymorphic-segmentation) 5.6.4 -> 5.6.7 across the platform + extensions + modes.
  • Regenerated pnpm-lock.yaml.

Testing

  • pnpm install resolves all @cornerstonejs/* packages to 5.6.7.
  • SEG save/load verified against a local Orthanc: a co-planar SEG that previously failed with the "orthogonal" error now loads and produces the expected segmentation.

Summary by CodeRabbit

  • Chores
    • Updated Cornerstone imaging, annotation, measurement, segmentation, reporting, and dynamic-volume components to the latest compatible 5.6.7 release.
    • Applied the same update across the application and core platform packages for improved consistency throughout the imaging experience.
    • No user-facing workflows or public interfaces were changed.

Updates all @cornerstonejs/* packages from 5.6.4 to 5.6.7. Notable fixes since
5.6.4:
- 5.6.7: load co-planar DICOM SEGs whose ImageOrientationPatient is delivered as
  DICOM DS strings (cornerstone3D #2816) — fixes SEGs being wrongly rejected as
  "orthogonal to the acquisition plane".
- 5.6.6: re-apply invert after a colormap when scrolling a stack (cornerstone3D
  #2814) — fixes invert being lost on scroll after a reset.
- 5.6.5: pin websocket-driver to 0.7.5.

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@sedghi
sedghi temporarily deployed to fork-pr-approval July 17, 2026 16:43 — with GitHub Actions Inactive
@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 0fe1e0f
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6a5a5ca7946a5d0008f9cbd6
😎 Deploy Preview https://deploy-preview-6161--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e756708a-37ad-4066-a0a7-99b7503ec40a

📥 Commits

Reviewing files that changed from the base of the PR and between df390a2 and 7017bfb.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (10)
  • extensions/cornerstone-dicom-pmap/package.json
  • extensions/cornerstone-dicom-seg/package.json
  • extensions/cornerstone-dicom-sr/package.json
  • extensions/cornerstone-dynamic-volume/package.json
  • extensions/cornerstone/package.json
  • extensions/measurement-tracking/package.json
  • extensions/usAnnotation/package.json
  • modes/usAnnotation/package.json
  • platform/app/package.json
  • platform/core/package.json

📝 Walkthrough

Walkthrough

Cornerstone.js dependencies and peer dependencies are updated from version 5.6.4 to 5.6.7 across Cornerstone extensions, the ultrasound annotation mode, and platform packages.

Changes

Cornerstone.js dependency alignment

Layer / File(s) Summary
Extension dependency updates
extensions/cornerstone*/package.json, extensions/measurement-tracking/package.json, extensions/usAnnotation/package.json
Cornerstone.js runtime and peer dependencies are bumped from 5.6.4 to 5.6.7.
Application and mode dependency updates
modes/usAnnotation/package.json, platform/app/package.json, platform/core/package.json
Application and mode dependencies, including platform peer dependencies, are updated to 5.6.7.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • OHIF/Viewers#6147: Updates related Cornerstone.js dependencies across overlapping packages.
  • OHIF/Viewers#6155: Updates Cornerstone.js dependency versions in the same package files.

Suggested labels: ohif-integration

Suggested reviewers: ohif-bot, jbocce, wayfarer3130

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise, semantic-release formatted, and accurately reflects the dependency version bump.
Description check ✅ Passed The description covers context, changes, and testing, but the checklist and some template fields are omitted.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-cornerstone-5.6.7

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cypress

cypress Bot commented Jul 17, 2026

Copy link
Copy Markdown

Viewers    Run #6572

Run Properties:  status check passed Passed #6572  •  git commit 0fe1e0ff98: Merge remote-tracking branch 'origin/master' into chore/bump-cornerstone-5.6.7
Project Viewers
Branch Review chore/bump-cornerstone-5.6.7
Run status status check passed Passed #6572
Run duration 01m 47s
Commit git commit 0fe1e0ff98: Merge remote-tracking branch 'origin/master' into chore/bump-cornerstone-5.6.7
Committer Alireza
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 28
View all changes introduced in this branch ↗︎

@sedghi
sedghi temporarily deployed to fork-pr-approval July 17, 2026 16:47 — with GitHub Actions Inactive
@sedghi
sedghi merged commit 583ef4d into master Jul 17, 2026
12 checks passed
dchansen06 pushed a commit to iCRcompany/OHIFViewer that referenced this pull request Jul 27, 2026
Bumps all @cornerstonejs/* packages 5.6.4 -> 5.6.7: SEG orientation string-IOP fix (OHIF#2816), invert-on-scroll fix (OHIF#2814), and websocket-driver 0.7.5 pin (5.6.5).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant