Skip to content

fix(worklist): disable supportsFuzzyMatching on staticWado AWS sources so patient-name search doesn't return empty - #6163

Merged
jbocce merged 2 commits into
OHIF:masterfrom
jbocce:fix/OHIF-6151
Jul 17, 2026
Merged

fix(worklist): disable supportsFuzzyMatching on staticWado AWS sources so patient-name search doesn't return empty#6163
jbocce merged 2 commits into
OHIF:masterfrom
jbocce:fix/OHIF-6151

Conversation

@jbocce

@jbocce jbocce commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Context

Fixes #6151

Changes & Results

disable supportsFuzzyMatching on staticWado AWS sources so patient-name search doesn't return empty

Testing

See #6151

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

System:
OS: Windows 11 10.0.26200
CPU: (20) x64 12th Gen Intel(R) Core(TM) i7-12700H
Memory: 4.37 GB / 31.68 GB
Binaries:
Node: 24.15.0 - C:\Users\joebo\AppData\Local\fnm_multishells\17164_1784096394247\node.EXE
Yarn: 1.22.22 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 11.12.1 - C:\Users\joebo\AppData\Local\fnm_multishells\17164_1784096394247\npm.CMD
pnpm: 11.5.2 - C:\Users\joebo\AppData\Local\pnpm\bin\pnpm.CMD
bun: 1.2.23 - C:\Users\joebo.bun\bin\bun.EXE
Browsers:
Chrome: 150.0.7871.115
Edge: Chromium (150.0.4078.65)
Internet Explorer: 11.0.26100.8115

Summary by CodeRabbit

  • Configuration
    • Disabled fuzzy matching for the default DICOMweb data source across standard, development, and demo environments.
    • Search behavior now relies on exact matching for configured data source queries.

…s so patient-name search doesn't return empty

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@netlify

netlify Bot commented Jul 17, 2026

Copy link
Copy Markdown

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit c8d17a2
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6a5a77537a23e40007cd54f0
😎 Deploy Preview https://deploy-preview-6163--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@jbocce
jbocce temporarily deployed to fork-pr-approval July 17, 2026 18:36 — with GitHub Actions Inactive
@jbocce
jbocce requested a review from sedghi July 17, 2026 18:37
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: a0d4b160-699e-46f9-a945-b86cd7132f79

📥 Commits

Reviewing files that changed from the base of the PR and between d485ebb and 4ba62cd.

📒 Files selected for processing (3)
  • platform/app/public/config/default.js
  • platform/app/public/config/dev.js
  • platform/app/public/config/netlify.js

📝 Walkthrough

Walkthrough

The default, development, and Netlify DICOMweb configurations change the OHIF data source’s supportsFuzzyMatching setting from true to false.

Changes

DICOMweb matching configuration

Layer / File(s) Summary
Disable fuzzy matching across configurations
platform/app/public/config/default.js, platform/app/public/config/dev.js, platform/app/public/config/netlify.js
The OHIF DICOMweb data source disables supportsFuzzyMatching in the default, development, and Netlify configurations.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: wayfarer3130

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is specific, concise, and matches the main change: disabling fuzzy matching for the patient-name search bug.
Description check ✅ Passed The PR description covers context, the change, testing, and checklist items, so it mostly matches the repository template.
Linked Issues check ✅ Passed The config change directly addresses #6151 by disabling fuzzy matching for the affected static WADO study-list sources.
Out of Scope Changes check ✅ Passed The diff only updates the relevant DICOMweb config values in three files and adds no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sedghi
sedghi temporarily deployed to fork-pr-approval July 17, 2026 18:41 — with GitHub Actions Inactive
@jbocce
jbocce merged commit 9cdea04 into OHIF:master Jul 17, 2026
8 checks passed
@jbocce
jbocce deleted the fix/OHIF-6151 branch July 17, 2026 18:59
dchansen06 pushed a commit to iCRcompany/OHIFViewer that referenced this pull request Jul 27, 2026
…s so patient-name search doesn't return empty (OHIF#6163)

Co-authored-by: Alireza <ar.sedghi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Patient name search does not work in the study list

2 participants