feat(storage): add Storage Provider contract (ADR-0001 + design spec)#26
Draft
alex-mabrouk wants to merge 4 commits into
Draft
feat(storage): add Storage Provider contract (ADR-0001 + design spec)#26alex-mabrouk wants to merge 4 commits into
alex-mabrouk wants to merge 4 commits into
Conversation
Introduce the Storage Provider abstraction that makes OKDP storage-agnostic: consumers depend on a stable, backend-neutral contract (defaultStorage: provider/buckets/grants) and each backend (SeaweedFS, RustFS, MinIO, Ceph RGW, AWS S3) implements it as an adapter, without ever referencing consumer contexts.
alex-mabrouk
added
enhancement
added 3 commits
July 7, 2026 19:08
Refactor the SeaweedFS package into a compliant adapter of the Storage Provider
contract (docs/design/storage-provider-contract.md): it now consumes ONLY
defaultStorage.{provider,buckets,grants} and no longer reaches into consumer
contexts (.Context.trino / .hiveMetastore / .jupyterHub / .sparkHistory / .polaris).
… local-secrets-provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make OKDP storage-agnostic by introducing a Storage Provider abstraction (Adapter pattern):
data services (Trino, Hive Metastore, Spark History, JupyterHub, Polaris) depend only on a stable,
backend-neutral contract (
defaultStorage:provider/buckets/grants), and each backend(SeaweedFS, RustFS, MinIO, Ceph RGW, AWS S3) implements it as an adapter that never references a
consumer context.
Today the SeaweedFS package is tightly coupled to every consumer (it reads
.Context.trino,.Context.hiveMetastore,.Context.polaris, …), so a second backend would be a full rewrite. ThisPR replaces that inverted dependency with a clean contract.
**Delivered in three commits **
docs: the contract — ADR-0001 (why) + design spec (how).refactor(seaweedfs): turn the SeaweedFS package into a compliant adapter consuming onlydefaultStorage.{provider,buckets,grants}(behaviour-preserving) + mirror the neutral contractinto the catalog contexts.
feat(rustfs): add RustFS as the second provider (official chart +mc-based provisioning Job).Related Issue
Fixes #25
Type of Change
How to Test
Contract review (this commit): read
docs/adr/0001-storage-provider-abstraction.mdanddocs/design/storage-provider-contract.md.End-to-end (once commits 2 & 3 land), validated locally on a Kind cluster:
built from
grants/buckets; Polaris STSAssumeRole+ real S3 write succeed.defaultStorage.provider.endpoints(+ name) and thedeployed infra Release: RustFS auto-provisions the 7 grants (users/policies) and 5 buckets, and
Polaris STS
AssumeRole+ write round-trip succeed — with zero change to any consumer.Checklist