Refactor the XMLInputBase class#899
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors XMLInputBase’s XML loading/parsing flow and updates the include-expansion logic to correctly handle included XML files that contain multiple top-level elements (a behavior regression after the tinyxml2 port).
Changes:
- Reworked include processing via an
XMLVisitorthat injects all top-level elements from included XML files. - Simplified prioritized-tag handling in
readXML()by inlining the logic and centralizing parse logging/error reporting. - Updated unit test and fixtures to cover multiple top-level tags in included files.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/SIM/XMLInputBase.h | Header cleanup and doc updates; removed now-unneeded priority helper declaration. |
| src/SIM/XMLInputBase.C | Refactored XML load/parsing, implemented updated include expansion, and reorganized priority parsing. |
| src/SIM/Test/TestXMLInputBase.C | Updated test helper and expectations for include behavior. |
| src/SIM/Test/included2.xml | Fixture extended to contain multiple top-level elements. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
with more than one top-level tag (as before the tinyxml2 port).
Collaborator
Author
|
jenkins build this with downstreams please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixing include of files with more than one top-level tag (as before the tinyxml2 port).