#13930 Viewer: Guard against empty frustum in per-model culling#13931
Merged
#13930 Viewer: Guard against empty frustum in per-model culling#13931
Conversation
Camera::computeViewFrustum() returns an empty Frustum if the projection matrix is degenerate (e.g., on the first paint after project open, before a valid near/far has been set). The per-model culling introduced by 82c7172 calls Frustum::isOutside() unconditionally, which asserts when the frustum has fewer than 6 planes. Skip culling when the frustum is not fully populated; all valid models then contribute to the near/far calculation, matching the pre-82c7172c1 behaviour.
jonjenssen
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cvf::Frustum::isOutsidewhen opening a project.Camera::computeViewFrustum()returns an empty Frustum if the projection matrix is degenerate (e.g., on the first paint after project open, before a validnear/farhas been set). The per-model culling introduced by 82c7172 callsFrustum::isOutside()unconditionally, which asserts when the frustum has fewer than 6 planes.See #13930 for full root-cause analysis.