Update surfio to latest and improve resdata robustness#14005
Merged
Conversation
magnesj
force-pushed
the
14004-update-file-import-libraries
branch
from
0cc2ec8 to
a7e9765
Compare
Collaborator
|
Try to avoid the "util_abort" calls in the ecl code if possible. Those will close ResInsight if an error happens. |
kriben
approved these changes
May 18, 2026
Guard zero-length keywords in ecl_kw_max_min, increase grdecl buffer to 256 and bound sscanf widths, and validate dimensions and keyword sizes (COORD, ZCORN, MAPAXES, CORSNUM, ACTNUM) when loading GRDECL grids.
magnesj
force-pushed
the
14004-update-file-import-libraries
branch
from
a7e9765 to
029726b
Compare
Member
Author
Replaced with logging and early return |
magnesj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the surfio submodule to 0.0.20. The new release introduces a parse_number/parse_number.h header that requires either std::from_chars float support or the fast_float library. ResInsight's custom-surfio wrapper now sets STD_FROM_CHARS_FLOAT_SUPPORT=0 and links FastFloat::fast_float (already declared in vcpkg.json)
Closes #14004.