Skip to content

Fix build bug and a compiler warnings.#152

Merged
lukelowry merged 4 commits into
lukel/phasor_tgov1_code_devfrom
slaven/phasor_tgov1_code_dev
Jun 25, 2025
Merged

Fix build bug and a compiler warnings.#152
lukelowry merged 4 commits into
lukel/phasor_tgov1_code_devfrom
slaven/phasor_tgov1_code_dev

Conversation

@pelesh

@pelesh pelesh commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

Description

  • Fix CMake bug preventing code to build on Linux/MacOS
  • Fix compiler warnings due to implicit conversion from unsigned to signed integer.

Closes #(issue)

Proposed changes

Needed quick fixes for #151

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@pelesh pelesh requested a review from lukelowry June 25, 2025 03:21
@pelesh pelesh self-assigned this Jun 25, 2025
@pelesh pelesh added bug Something isn't working cmake compiler warnings labels Jun 25, 2025

@lukelowry lukelowry left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not receive compiler warnings without these changes, but I trust these changes are generally needed. Thank you for the formatting adjustments as well.

@lukelowry lukelowry merged commit 6135c3c into lukel/phasor_tgov1_code_dev Jun 25, 2025
@lukelowry

Copy link
Copy Markdown
Collaborator

Merged. Thank you

@lukelowry lukelowry deleted the slaven/phasor_tgov1_code_dev branch June 26, 2025 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cmake compiler warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants