cmake: fix Native Language Support (NLS) support - #5297
Merged
Conversation
github-actions
Bot
added
CI
Contributor
Author
|
#5269 is merged, this is now ready too. |
echoix
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Native Language Support (NLS) support with CMake builds.
This is another reason to increase CMake required version to 3.22 (#5269). The version of FindIntl from 3.16 is not particularly good and we'll have to use a custom one if staying with 3.16.I included here the version of 3.22, for "proof of concept".