docs: Fix crash and simplify git calls in mkdocs generation#7604
Conversation
|
The CI addon compilation reports success for almost all addons. |
|
My opinion is that better solution is switching from the Make to CMake (which setting -DPYTHON_EXECUTABLE) for compiling addons in the CI. CI use compile_addons_git.sh BASH script with Make command for addons compilation, but g.extension use CMake.
|
It might be a good next step, let’s keep the idea |
|
@petrasovaa to be backported to G8.5? |
|
I am not sure whether 8.5 has the same problem. It's probably harmless to backport. |
* docs: Fix crash and simplify git calls in mkdocs generation * exit instead of just writing message
* docs: Fix crash and simplify git calls in mkdocs generation * exit instead of just writing message
This is trying to resolve regression after #7310 causing problems in addon compilation in CI. To be honest I am not sure I quite understand the exact mechanism, why gs is None in CI, but this PR should hopefully address the problems in logs like:
This PR replaces gs.Popen/decode calls with standard Python calls.
One change I am not sure about is in
get_addon_pathwhere if gs was not available, it replaced fatal with sys.stderr.write, which is not the same, it does not exit. That seemed like unintentional, so I replaced it with sys.exit, but I am not sure about that.