r.geomorphon: replace testsuite with pytest reference - #7785
Open
krcoder123 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
raster
petrasovaa
reviewed
Jul 29, 2026
petrasovaa
reviewed
Jul 29, 2026
petrasovaa
requested changes
Jul 29, 2026
petrasovaa
left a comment
petrasovaa
left a comment
Contributor
There was a problem hiding this comment.
Remove all the nprocs tests, they will be needed in the parallelization PR.
|
|
||
| # A polynomial of row and col with cubic terms so curvature varies and | ||
| # several landform classes appear without any rand or trig. | ||
| DEM_EXPRESSION = ( |
Contributor
There was a problem hiding this comment.
This results only in a few classes.
krcoder123
force-pushed
the
rgeomorphon-pytest
branch
from
July 29, 2026 23:44
5f9c8bc to
1674d91
Compare
krcoder123
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the old gunittest testsuite for r.geomorphon with pytest. It has 8 reference tests checking output statistics on a small deterministic DEM across the main option combinations. It also has 4 parallel correctness tests that compare multi thread output against single thread. The parallel tests are marked skip for now since the module has no nprocs option yet. But, the skip gets removed in the parallelization PR #7783 once this merges.