Add ordered_complement helper, vectorize diff branch, and tweak vignette headers#138
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
np.setdiff1din resampling code while preserving the original index order for training/validation splits._dy_d_best_planby removing looped index bookkeeping and using array reshaping and vectorized operations.Description
src/nns/_indices.pyimplementingordered_complement(all_index, excluded)which returns the values ofall_indexnot present inexcludedwhile preserving input order.np.setdiff1d(all_index, ...)withordered_complementinsrc/nns/boost.pyandsrc/nns/stack.pyfor training/validation index construction.src/nns/diff.py::_dy_d_best_planto compute per-group means by reshaping the prediction block and computeFirstandSecondarrays with vectorized arithmetic, removingposition/idsbookkeeping and looped element-wise aggregation.examples/vignettes/03_correlation_and_dependence.pyand04_normalization_and_rescaling.py) to adjust header comments and docstrings and tidy imports.tests/invariants/test_indices.pyasserting thatordered_complementpreserves the source index order.Testing
pytest tests/invariants/test_indices.pyand it passed.Codex Task