fix(explorer): restore readable text color regression from #784#788
fix(explorer): restore readable text color regression from #784#788PRAteek-singHWY wants to merge 1 commit intoOWASP:mainfrom
Conversation
|
@PRAteek-singHWY if I am not wrong the original theme of the background was not white it is introduced in PR #768 and now in this PR we are again struggling with readability issue because of theme changes. Is this theme change planned for the website? |
Hi @manshusainishab That PR was raised to resolve the issue where a white background appeared during overscrolling. PR #768 addressed the overscrolling behavior itself and restored the default body background to white. You can also check the video attached in PR #768 to see what was breaking earlier after PR #767. To be sure, you can also check some older merged PRs where screenshots are attached — the background there is clearly white. Also, your thought about supporting theming based on system preference sounds like a good idea. As far as I know, a specific theme design has not been formally discussed yet, so it might be worth bringing it up with the maintainers to see how they would like to approach it. |
|
Thanks for the clarification @PRAteek-singHWY I thought the original colour was not white because when I was fixing the readability issue I applied the text with white colour because background was dark at that time on main branch |
Summary
Fixes a text-contrast regression introduced by #784 on
/explorer, where heading/body text became near-white on a light background.What changed
Before
After
Verification
/explorerand confirmed text is readable without selecting/highlighting.