Fix: Prevent infinite loop in gap_analysis preload (#885)#895
Open
PRAteek-singHWY wants to merge 2 commits intoOWASP:mainfrom
Open
Fix: Prevent infinite loop in gap_analysis preload (#885)#895PRAteek-singHWY wants to merge 2 commits intoOWASP:mainfrom
PRAteek-singHWY wants to merge 2 commits intoOWASP:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an infinite loop bug in the
gap_analysis.pybackground runner that could permanently lock up the application when checking standard pairings.What Changed
MAX_RETRIES = 10threshold so failing pairs are correctly dropped from the waiting list instead of being retried endlessly.(sa, sb)to prevent redundant checking of already succeeded pairs.if waiting:check to safely skip the unnecessary 30-second sleep on the final successful loop iteration.fixes #885