fix(spreadsheet_parsers): correct function name for validating import…#903
Merged
Conversation
Contributor
Author
Pa04rth
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #902
Description
parse_export_formatat application/utils/spreadsheet_parsers.py:206 callsvalidate_export_csv_rows(lfile), but no such function exists anywhere in the repo —git grepfinds only this single call site, with nodef. The function with the intended behaviour isvalidate_import_csv_rows, defined in the same file at line 138, with an identical signature (List[Dict[str, Any]] -> List[Dict[str, Any]]) and the same validation purpose.The call was introduced by #683 (commit 4de782b, "refactor(csv-import): move CSV validation into spreadsheet parser"). That refactor extracted the validator under the
_import_name and updatedparse_import_formatto call it, but missed updating this one call insideparse_export_format. Looks like a copy/paste typo carried over from the rename.Effect on
main: any invocation ofparse_export_formatraisesNameError: name 'validate_export_csv_rows' is not defined, andapplication/tests/spreadsheet_parsers_test.py::TestParsers::test_parse_export_formatfails on every run.Fix
One line.
s/validate_export_csv_rows/validate_import_csv_rows/atapplication/utils/spreadsheet_parsers.py:206. No imports change, no behaviour change at the call site beyond resolving the reference, and there are no other callers (grep confirms).Scope
Single-line change to a single file. No refactor, no rename, no new tests — the existing
test_parse_export_formatalready covers this path and now passes.