refactor: replace any type assertion with Parameters<typeof writeHtmlReport>[0]#439
Merged
sonukapoor merged 1 commit intoMay 25, 2026
Conversation
sonukapoor
approved these changes
May 25, 2026
Collaborator
sonukapoor
left a comment
sonukapoor
left a comment
There was a problem hiding this comment.
Clean change. Parameters<typeof writeHtmlReport>[0] is the right type here - no extra import needed and stays in sync automatically if the function signature ever changes.
One thing before this can merge: the branch is behind main. Could you rebase against main and force-push?
…Report>[0] closes #438
AnupamKumar-1
force-pushed
the
fix/remove-any-type-assertion-cli-integration
branch
from
751444e to
11454e9
Compare
Contributor
Author
|
Rebased against main and force-pushed the updated branch. Thanks for the review! |
Collaborator
|
@AnupamKumar-1 Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #438
Summary
Replaced
const callArgs: anywithconst callArgs: Parameters<typeof writeHtmlReport>[0]on line 867 — inline, no extra import needed.Why this change
anybypasses TypeScript's type checker. Proper type ensures compile-time safety.What changed
tests/cli-integration.test.tsline 867:any→Parameters<typeof writeHtmlReport>[0]Validation
npm test— 326 tests passnpm run build— build cleanUser-facing impact
Notes
Test file change only, no runtime behaviour changed.