Skip to content

fix(visual-qa): capture current adaptive surfaces #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veryCrunchy merged 5 commits into from
Jul 27, 2026
Merged

fix(visual-qa): capture current adaptive surfaces #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a169a6c
fix(visual-qa): capture current adaptive surfaces
veryCrunchy Jul 27, 2026
f0e076c
fix(visual-qa): refresh capture provenance
veryCrunchy Jul 27, 2026
10899cb
fix(dynamic-ui): preserve adaptive table actions
veryCrunchy Jul 27, 2026
19db6fb
Merge remote-tracking branch 'origin/main' into fix/233-production-ca…
veryCrunchy Jul 27, 2026
efb376b
fix(dynamic-ui): expose table actions on long press
veryCrunchy Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions changes/unreleased/233-production-captures.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
category: fix

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 27, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore human authorship and DCO sign-off

The reviewed commit records Codex <codex@openai.com> as both author and committer, and its message has no human Signed-off-by trailer. This commit therefore cannot be submitted under the repository's authorship and DCO contract; recreate it with the responsible human contributor as author/committer and add their sign-off only after they explicitly review and authorize it.

AGENTS.md reference: AGENTS.md:L359-L365

Useful? React with 👍 / 👎.

issue: 233
pull: 235
platforms: android, desktop, website
user-facing: yes

Home and adaptive data captures now use the production dashboard and table presentations, including wrapped shortcuts and native record cards on compact screens.
89 changes: 67 additions & 22 deletions ui/src/commonMain/kotlin/dev/obiente/nextcloudnative/app/DashboardStatusScreens.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package dev.obiente.nextcloudnative.app
import androidx.compose.foundation.clickable
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.FlowRow
import androidx.compose.foundation.layout.PaddingValues
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.Spacer
Expand Down Expand Up @@ -77,8 +78,6 @@ internal fun NativeDashboardScreen(
onSettings: (() -> Unit)? = null,
) {
var refreshAttempt by remember(session) { mutableStateOf(0) }
var customizeWorkspace by remember(session) { mutableStateOf(false) }
var workspacePersistenceError by remember(session) { mutableStateOf<String?>(null) }
val state = rememberNativeDashboardState(
services = services,
session = session,
Expand All @@ -99,12 +98,65 @@ internal fun NativeDashboardScreen(
mutableStateOf(workspaceRepository.load(workspaceScope))
}

NativeDashboardPresentation(
state = state,
installedApps = installedApps,
workspaceLayout = workspaceLayout,
onWorkspaceLayoutChanged = { updated ->
workspaceLayout = updated
workspaceRepository.save(updated)
},
onOpenApp = onOpenApp,
onOpenStatus = onOpenStatus,
onOpenLink = { link ->
val appId = dashboardAppIdForLink(session, link)
val nativeApp = installedApps.firstOrNull { it.id == appId }
if (nativeApp != null) {
onOpenApp(nativeApp)
} else {
services.openExternalUrl(dashboardBrowserUrl(session, link))
}
},
onBack = onBack,
onRefresh = { refreshAttempt += 1 },
onSearch = onSearch,
onSettings = onSettings,
)
}

/**
* Shared production dashboard presentation.
*
* The authenticated host owns transport, cache, account identity, and persistence. Deterministic
* captures can provide synthetic state without replacing the UI with a separate preview screen.
*/
@Composable
internal fun NativeDashboardPresentation(
state: DashboardSurfaceState,
installedApps: List<NextcloudAppEntry>,
workspaceLayout: HomeWorkspaceLayout,
onWorkspaceLayoutChanged: (HomeWorkspaceLayout) -> Boolean,
onOpenApp: (NextcloudAppEntry) -> Unit,
onOpenStatus: (() -> Unit)?,
onOpenLink: (String) -> Unit,
onBack: (() -> Unit)?,
onRefresh: () -> Unit,
onSearch: (() -> Unit)? = null,
onSettings: (() -> Unit)? = null,
) {
var customizeWorkspace by remember(workspaceLayout.scope) { mutableStateOf(false) }
var workspacePersistenceError by remember(workspaceLayout.scope) { mutableStateOf<String?>(null) }
var activeWorkspaceLayout by remember(workspaceLayout.scope) { mutableStateOf(workspaceLayout) }
LaunchedEffect(workspaceLayout) {
if (workspaceLayout != activeWorkspaceLayout) activeWorkspaceLayout = workspaceLayout
}

Column(modifier = Modifier.fillMaxSize()) {
DashboardHeader(
title = "Home",
subtitle = "Your cloud at a glance",
onBack = onBack,
onRefresh = { refreshAttempt += 1 },
onRefresh = onRefresh,
onCustomize = { customizeWorkspace = true },
onSearch = onSearch,
onSettings = onSettings,
Expand All @@ -113,7 +165,7 @@ internal fun NativeDashboardScreen(
DashboardSurfaceState.Loading -> DashboardLoading()
is DashboardSurfaceState.Failed -> DashboardFailure(
message = current.message,
onRetry = { refreshAttempt += 1 },
onRetry = onRefresh,
)
is DashboardSurfaceState.Available -> {
val bindings = remember(current.snapshot.widgets) {
Expand All @@ -127,13 +179,13 @@ internal fun NativeDashboardScreen(
}
}
}
val effectiveLayout = remember(workspaceLayout, availableSectionIds) {
workspaceLayout.reconcileAvailableSections(availableSectionIds)
val effectiveLayout = remember(activeWorkspaceLayout, availableSectionIds) {
activeWorkspaceLayout.reconcileAvailableSections(availableSectionIds)
}
LaunchedEffect(effectiveLayout) {
if (effectiveLayout != workspaceLayout) {
workspaceLayout = effectiveLayout
workspaceRepository.save(effectiveLayout)
if (effectiveLayout != activeWorkspaceLayout) {
activeWorkspaceLayout = effectiveLayout
onWorkspaceLayoutChanged(effectiveLayout)
}
}
val bindingsBySection = remember(bindings) {
Expand Down Expand Up @@ -164,15 +216,7 @@ internal fun NativeDashboardScreen(
widget = binding.widget,
items = current.snapshot.itemsByWidget[binding.widget.id].orEmpty(),
size = section.size,
onOpenLink = { link ->
val appId = dashboardAppIdForLink(session, link)
val nativeApp = installedApps.firstOrNull { it.id == appId }
if (nativeApp != null) {
onOpenApp(nativeApp)
} else {
services.openExternalUrl(dashboardBrowserUrl(session, link))
}
},
onOpenLink = onOpenLink,
)
}
}
Expand All @@ -192,8 +236,8 @@ internal fun NativeDashboardScreen(
workspacePersistenceError = null
},
onSave = { updated ->
workspaceLayout = updated
if (workspaceRepository.save(updated)) {
activeWorkspaceLayout = updated
if (onWorkspaceLayoutChanged(updated)) {
customizeWorkspace = false
workspacePersistenceError = null
} else {
Expand Down Expand Up @@ -407,11 +451,12 @@ private fun DashboardQuickActionsCard(
color = MaterialTheme.colorScheme.onSurfaceVariant,
)
} else {
LazyRow(
FlowRow(
modifier = Modifier.fillMaxWidth().padding(top = NextcloudSpacing.Medium),
horizontalArrangement = Arrangement.spacedBy(NextcloudSpacing.Small),
verticalArrangement = Arrangement.spacedBy(NextcloudSpacing.XSmall),
) {
items(quickApps, key = NextcloudAppEntry::id) { app ->
quickApps.forEach { app ->
FilterChip(
selected = false,
onClick = { onOpenApp(app) },
Expand Down
Loading
Loading