feat(windows): ship verified unsigned MSI releases - #274
Conversation
veryCrunchy
added
priority:P1
veryCrunchy
added
area:platform
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f411d5e72a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f411d5e to
73fcc4d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73fcc4ded4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4752776 to
c4af4ac
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4af4accc2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
c4af4ac to
2fbc2ab
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 588baeca89
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1cb7a82 to
b8154d0
Compare
b8154d0 to
2db1b89
Compare
1 participant
Summary
Security model
The project does not currently use paid Authenticode signing. This removes the unused PFX secret path and rejects self-signed or unexpectedly signed packages. Release workflows verify the explicit unsigned state, attest the exact MSI produced from protected release source, and publish checksums. Release notes state that Windows may require
More info > Run anywayand that managed devices may block unsigned installers.GitHub provenance is an integrity and source-origin control; it is not presented as an Authenticode publisher signature.
Validation
bash tools/check-repository.shbash tools/test-nightly-release-workflow.shnode --test tools/nightly-release-notes.test.mjsgo run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 -color .github/workflows/ci.yml .github/workflows/nightly.yml .github/workflows/prerelease.yml./gradlew --no-daemon --max-workers=1 -Pkotlin.incremental=false -Pkotlin.compiler.execution.strategy=in-process :ui:desktopTestwith JDK 21 and FUSE 2 availableThe GitHub-hosted Windows job remains the authoritative MSI, Windows Credential Manager, MSI metadata, and WinGet generation validation.
Stacked on #272.
Refs #102.