fix(auth): bind login and DAV requests to account by veryCrunchy · Pull Request #428 · Obiente/native

veryCrunchy · 2026-09-01T18:08:43Z

What changed

share Login Flow polling transport between Android and desktop
support reverse proxies that require the explicit index.php/login/v2/poll endpoint
reject malformed server URLs before starting Login Flow
attach DAV credentials only after the target matches the account origin and base path
disable automatic redirects and follow only bounded, validated redirects
permit 301/302 only for bodyless GET/HEAD requests; reject method-changing mutation redirects
preserve stable redirect diagnostics at Android and desktop DAV boundaries
route Android DocumentsProvider DAV and range hashing through the shared policy
keep retryable Login Flow polling responses retryable

Validation

focused Login Flow, authenticated-request policy, and redirect tests
focused Android DocumentsProvider DAV and range-hash transport tests
full DesktopFileSyncRemoteTreeTest and NextcloudDocumentWebDavTest regression suites
bash tools/check-kotlin-architecture.sh
bash tools/check-repository.sh
./gradlew --no-daemon --max-workers=1 :androidApp:assembleDebug :ui:createDistributable

Limits

Desktop chunk uploads, detached downloads, and broader service call sites still need migration to the same authenticated executor.

Advances #106
Advances #405

obiente-cloud · 2026-09-01T18:08:48Z

Obiente preview

NC Native · 7cd1d7f030dd · Removed

View preview status

View in Obiente

_{Obiente updates this comment as the preview changes.}

chatgpt-codex-connector · 2026-09-01T18:08:56Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-03T23:57:21.649889Z	`7cd1d7f`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa064009a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4871dcd70a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 699cf4441e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cce4237b48

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7667a02d60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: af2c1a0213

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Route desktop chunk-upload reads and mutations through the account-bound authenticated request policy. Preserve method and body only for validated redirects, keep cancellation active on each hop, and classify post-exchange mutation failures as ambiguous.\n\nAdvances #106

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e3fc1bb5e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 31760fdcc9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9c6e6cc75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…uest-target-policy

fix(auth): bind login and DAV requests to account

fa06400

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 18:08 Destroyed

chore(changelog): link pull request

4871dcd

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 18:10 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread ui/src/jvmMain/kotlin/dev/obiente/nextcloudnative/app/JvmLoginFlowTransport.kt Outdated

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/NextcloudDocumentWebDav.kt

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread ui/src/jvmMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudAuthenticatedRequestPolicy.kt Outdated

Comment thread ui/src/jvmMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudAuthenticatedRequestPolicy.kt

fix(auth): preserve retryable login polling

8f5382b

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 18:33 Destroyed

fix(auth): route range hashing through request policy

699cf44

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 18:36 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread ui/src/jvmMain/kotlin/dev/obiente/nextcloudnative/app/JvmLoginFlowTransport.kt Outdated

fix(auth): constrain redirects and preserve diagnostics

cce4237

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 18:59 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread ui/src/jvmMain/kotlin/dev/obiente/nextcloudnative/app/LoginEndpointSecurity.kt

veryCrunchy mentioned this pull request Sep 1, 2026

fix(auth): bind detached downloads to account #432

Merged

fix(auth): stabilize login fallback polling

7667a02

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 19:24 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread androidApp/src/main/kotlin/dev/obiente/nextcloudnative/NextcloudDocumentWebDavModels.kt Outdated

fix(auth): stop retrying rejected redirects

af2c1a0

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 19:49 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

Comment thread ui/src/desktopMain/kotlin/dev/obiente/nextcloudnative/app/DesktopFileSyncRemoteTree.kt

Comment thread ui/src/jvmMain/kotlin/dev/obiente/nextcloudnative/app/JvmLoginFlowTransport.kt

veryCrunchy added 2 commits September 1, 2026 22:12

fix(auth): report compatibility polling accurately

bd8397a

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 20:16 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

fix(tests): stabilize receipt restart wait

11a777a

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 20:48 Destroyed

fix(auth): align Android login policy

31760fd

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 21:09 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

fix(transport): harden redirect recovery

9de78c6

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 1, 2026 22:31 Destroyed

fix(sync): avoid replaying nullable HTTP results

e9c6e6c

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 3, 2026 22:04 Destroyed

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread ui/src/jvmMain/kotlin/dev/obiente/nextcloudnative/app/NextcloudAuthenticatedRequestPolicy.kt Outdated

fix(auth): accept literal percent signs in DAV paths

c5d3ef7

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 3, 2026 23:36 Destroyed

veryCrunchy added 2 commits September 4, 2026 01:39

Merge remote-tracking branch 'origin/main' into fix/authenticated-req…

1af651e

…uest-target-policy

refactor(repo): split oversized Kotlin sources

7cd1d7f

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #428 / NC Native September 3, 2026 23:52 Destroyed

veryCrunchy merged commit 0710b96 into main Sep 4, 2026
4 checks passed

Uh oh!

Conversation

veryCrunchy commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed

Validation

Limits

Uh oh!

obiente-cloud Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Obiente preview

Uh oh!

chatgpt-codex-connector Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

veryCrunchy commented Sep 1, 2026 •

edited

Loading

obiente-cloud Bot commented Sep 1, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 1, 2026 •

edited

Loading