feat(accounts): add platform credential slots by veryCrunchy · Pull Request #436 · Obiente/native

veryCrunchy · 2026-09-01T20:42:50Z

Outcome

Add bounded Android and desktop credential slots keyed by the opaque local account identity from feat(accounts): add account identity registry foundation #429.
Migrate the existing Android encrypted session and desktop secret-store entry without binding one account metadata record to another account password.
Keep account selection and removal behind the existing Android sync-scheduling and desktop session-publication guards. Desktop selection is rejected while file ranges, kept-folder hydration, virtual-file providers, or cache moves are active.
Add the shared account credential service contract. This is an internal foundation; it does not add the account-picker UI yet.

Advances #172. This PR depends on #429.

Verification

Focused Android account credential persistence tests pass
Focused desktop credential persistence and secret-reference tests pass
Android debug APK assembly passes
Desktop distributable creation passes
Kotlin architecture checks pass
Full repository hygiene passes
A new changes/unreleased fragment records the change
No credentials, private server data, machine-local paths, or generated output are included

Build-host commands:

./gradlew --no-daemon --max-workers=1 -Pkotlin.incremental=false :androidApp:testDebugUnitTest --tests dev.obiente.nextcloudnative.AndroidPersistedSessionTest :ui:desktopTest --tests dev.obiente.nextcloudnative.app.DesktopAccountCredentialPersistenceTest --tests dev.obiente.nextcloudnative.app.DesktopSecretStoreTest
./gradlew --no-daemon --max-workers=1 -Pkotlin.incremental=false :androidApp:assembleDebug :ui:createDistributable
bash tools/check-kotlin-architecture.sh
bash tools/check-repository.sh

The full source and packaging validation ran on exact #429 parent 78eb576fc8881a246feb1fac8b0b443d4ed1b903. Before publication, #429 advanced to f0696b474a625bd52dfffb29d5695a0a8f996265 with only a one-line automated marketing capture-manifest update. The child source was unchanged. The final child commit only links this PR number in the already-validated changelog fragment.

Compatibility and risk

Covered platforms: Android and desktop JVM targets. No device, emulator, live server, macOS keychain, Windows Credential Manager, or Linux Secret Service end-to-end run was performed.
Android keeps the existing encrypted SharedPreferences owner and migrates versionless session payloads to a bounded multi-slot store. Corrupt or mismatched metadata and credentials are rejected without overwrite.
Desktop moves credentials to opaque account-ID secret references and retains compatibility metadata during migration. Selection does not proceed while old-account file resources are live.
Account selection is exposed only through the platform service contract in this slice; user-facing account management remains follow-up work.

Visual changes

Not applicable.

obiente-cloud · 2026-09-01T20:42:55Z

Obiente preview

NC Native · 722eb3909a50 · Ready

Open preview

View in Obiente

_{Obiente updates this comment as the preview changes.}

chatgpt-codex-connector · 2026-09-01T20:43:00Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-09-04T21:39:13.268005Z	`a4bdee1`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5e6014e2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0bb0e52ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6dabe16e75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5849f1719f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7931ce047

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b1e4cb658

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0526df17f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bbc70fc564

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a80069c147

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-09-05T22:36:26Z

        }
    }
+    private suspend fun retryPendingAccountSyncPairCleanup(accountId: String) {
+        accountSyncPairCleanupJournal.pending().singleOrNull { it.accountId == accountId }?.let { cleanup ->


Match pending cleanup by canonical account identity

When committed cleanup remains pending, re-adding the same logical account with a canonically equivalent URL can produce a different desktopFileCacheAccountId while retaining the same NextcloudAccountId and accountStorageKey. This lookup only checks the raw URL-derived cache ID passed by saveSession, so reactivation proceeds; a later background retry then processes the committed tombstone and can delete new Deck drafts keyed by the shared accountStorageKey. Match or block pending cleanup using the tombstone's canonical account storage key, not only its cache ID.

AGENTS.md reference: AGENTS.md:L410-L413

Useful? React with 👍 / 👎.

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 1, 2026 20:42 Destroyed

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 1, 2026 20:43 Destroyed

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 1, 2026 20:49 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

veryCrunchy mentioned this pull request Sep 1, 2026

fix(android): preserve account-owned background uploads #438

Open

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 1, 2026 21:49 Destroyed

chatgpt-codex-connector Bot reviewed Sep 1, 2026

View reviewed changes

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 3, 2026 20:37 Destroyed

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 3, 2026 20:51 Destroyed

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 3, 2026 21:06 Destroyed

veryCrunchy force-pushed the feature/account-credential-slots branch from d6d0017 to 4daca37 Compare September 3, 2026 21:08

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 3, 2026 21:08 Destroyed

veryCrunchy force-pushed the feature/account-credential-slots branch from 4daca37 to f7931ce Compare September 3, 2026 21:14

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 3, 2026 21:14 Destroyed

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 3, 2026 21:37 Destroyed

chatgpt-codex-connector Bot reviewed Sep 3, 2026

View reviewed changes

veryCrunchy force-pushed the feature/account-credential-slots branch from 0b1e4cb to c0526df Compare September 4, 2026 00:39

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 4, 2026 00:39 Destroyed

chatgpt-codex-connector Bot reviewed Sep 4, 2026

View reviewed changes

veryCrunchy force-pushed the feature/account-credential-slots branch from c0526df to bbc70fc Compare September 4, 2026 01:10

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 4, 2026 01:10 Destroyed

obiente-cloud Bot temporarily deployed to Obiente Preview / PR #436 / NC Native September 4, 2026 01:15 Destroyed

chatgpt-codex-connector Bot reviewed Sep 4, 2026

View reviewed changes

veryCrunchy force-pushed the feature/account-credential-slots branch from 28965a7 to 1d310d0 Compare September 4, 2026 01:56

veryCrunchy and others added 29 commits September 6, 2026 00:32

fix(accounts): retry desktop removal cleanup

8910cad

fix(desktop): remove accounts without loading secrets

7bc51c9

fix(windows): purge removed Cloud Files roots

c7eb755

fix(android): revoke handoffs across account transitions

c31c9b3

fix(accounts): retain preview cleanup recovery

4cb3077

test(accounts): fix preview cleanup fixtures

f553484

fix(accounts): clear unreadable active ownership

9399e24

fix(accounts): preserve unreadable removal rollback

80e19bc

fix(accounts): retain original preview retry identity

8470e99

fix(uploads): retain jobs for unreadable account registry

f6e194d

fix(desktop): recover malformed cleanup phases

0f2b601

fix(android): finish committed account selection

52e51ce

fix(accounts): purge retained mutation recovery

9b5236f

fix(accounts): persist mutation cleanup retries

3fc1b08

chore(website): refresh marketing captures

036f681

fix(account): purge private state after removal

7118ccb

chore(website): refresh marketing captures

573d66f

fix(account): serialize private-state publication

5d9901b

chore(website): refresh marketing captures

00b5546

fix(account): purge removal residual state

b1747c9

fix(desktop): clear legacy handoffs on removal

9735767

test(android): make media cleanup deterministic

6b66f5c

fix(account): close residual cleanup races

4cc89c5

fix(desktop): reserve external handoff cache budget

df1a3a0

chore(website): refresh marketing captures

e7a8096

fix(desktop): recover credential removals

ac74009

fix(desktop): validate handoff paths portably

47029ef

fix(accounts): retire deck draft state

4ac4147

fix(desktop): delete read-only handoff copies

722eb39

chatgpt-codex-connector Bot reviewed Sep 5, 2026

View reviewed changes

Uh oh!

Conversation

veryCrunchy commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Outcome

Verification

Compatibility and risk

Visual changes

Uh oh!

obiente-cloud Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Obiente preview

Uh oh!

chatgpt-codex-connector Bot commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

veryCrunchy commented Sep 1, 2026 •

edited

Loading

obiente-cloud Bot commented Sep 1, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 1, 2026 •

edited

Loading