docs(deploy): fix Certbot-include repair command (missing path on chmod/chown) - #28
Merged
Conversation
…od/chown) The documented recovery command abbreviated `sudo chmod 644` and `sudo chown root:root` without the target path, so an operator copy-pasting it would hit a missing-operand error and skip the permission/ownership step. Pass the full /etc/letsencrypt/le_http_01_cert_challenge.conf path to touch, chmod, and chown, and update the recurrence note to re-run all three (not a bare touch, which wouldn't restore mode/ownership).
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDocumentation-only fix to make the Certbot include recovery command copy-pasteable and ensure the recreated file has the required mode and ownership. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses a code-review comment on PR #27. The documented recovery command wrote 'sudo chmod 644' and 'sudo chown root:root' without the target path, so an operator copy-pasting it after the Certbot include disappears would hit a missing-operand error and skip enforcing permissions/ownership. Pass the full path to touch, chmod, and chown, and update the recurrence note to re-run all three commands (a bare touch would not restore mode/ownership). Docs only.
Summary by Sourcery
Documentation: