Make User#tag return unique username instead of display name#73
Merged
Conversation
Vendicated
changed the title
Vendicated
changed the title
DonovanDMC
requested changes
Jun 27, 2023
DonovanDMC
previously approved these changes
Jun 27, 2023
auto-merge was automatically disabled
June 27, 2023 19:18
Head branch was pushed to by a user without write access
Contributor
Author
|
fixed lint! sorry, i just made the initial commit via github since it was such a minor edit and i was too lazy to clone and open vscode :P But eslint memberSorting got my ass 💔 |
DonovanDMC
approved these changes
Jun 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the point of .tag previously was to get the unique username you can use to add people (username + discrim), so for migrated users, it is logical to also return their unique username. Returning the non unique global displayName makes no sense to me. If people wanted that, they would instead use user.displayName
Also made isMigrated public because it's useful for libvrary users