Skip to content

Make User#tag return unique username instead of display name #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DonovanDMC merged 4 commits into from
Jun 27, 2023
Merged

Make User#tag return unique username instead of display name #73

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eee96ed
Update User.ts
Vendicated Jun 27, 2023
4ef26ee
remove obsolete non null assertion
Vendicated Jun 27, 2023
3ce97a0
fix docs
DonovanDMC Jun 27, 2023
44b1aac
Fix lint
Vendicated Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lib/structures/User.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,6 @@ export default class User extends Base {
}
}

private get isMigrated(): boolean {
return this.globalName !== null && (this.discriminator === undefined || this.discriminator === "0");
}

/** The default avatar value of this user. */
get defaultAvatar(): number {
if (this.isMigrated) {
Expand All @@ -80,15 +76,20 @@ export default class User extends Base {
return Number(this.discriminator) % 5;
}

/** If this user has migrated to the new username system. */
get isMigrated(): boolean {
return this.globalName !== null && (this.discriminator === undefined || this.discriminator === "0");
}

/** A string that will mention this user. */
get mention(): string {
return `<@${this.id}>`;
}

/** This user's display name, if migrated, else a combination of the user's username and discriminator. */
/** This user's unique username, if migrated, else a combination of the user's username and discriminator. */
get tag(): string {
if (this.isMigrated) {
return this.globalName!;
return this.username;
}
return `${this.username}#${this.discriminator}`;
}
Expand Down