upload_file: form-encode files.getUploadURLExternal (rejects JSON, seen live) - #10
Merged
Merged
Conversation
…valid_arguments live Slack rejects a JSON body on the reserve call (missing required field: filename/length despite both being present). Form-encode it; the complete call stays JSON. Regression test pins the content type. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First live use of
upload_filefailed:files.getUploadURLExternalis one of Slack's form-only endpoints and answers a JSON body withinvalid_arguments: missing required field: filename/length. Reproduced from the VM with curl (JSON fails, form works). Fix: form-encode the reserve call;files.completeUploadExternalkeeps JSON. Regression test asserts the content type and form body.Already hotfixed on tag-daemon (scp + restart, verified by content).
🤖 Generated with Claude Code