Skip to content

rubric regex parsing ban #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Octember wants to merge 4 commits into
base: main
Choose a base branch
from
Open

rubric regex parsing ban #40

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9ace7b
site: hero heading -> "Clever code is a liability"
Octember Jun 28, 2026
79a4759
docs(rubric): flag regex/string-matching parsing of structured data a…
Octember Jul 2, 2026
b0821c3
reword: regex is never the product mechanism
Octember Jul 2, 2026
68c2c79
review: drop unrelated hero churn
Octember Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .review/RUBRIC.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ Edit it to match your team. Findings fall into two categories.
- a defensive `?.` / `??` fallback on a value the type or schema already guarantees — e.g. `x?.foo ?? x.y.foo`
when `x` is required (or should be). Drop the optional chain and the fallback (it's `x.foo`); if `x` is
wrongly optional, fix the schema/type, don't paper over it at the call site
- regex or string matching as the product mechanism — detecting, classifying, routing, or extracting
meaning by sniffing strings (`match`/`split`/`includes` heuristics). A fake owner: works on the examples
tried, silently breaks on the next input. **fix:** the structured field, schema, persisted state, real
parser, or model output that actually owns the answer. String matching is plumbing for flat text only
- denormalized parallel constants or hardcoded membership lists (derive a Set/Record from ONE `as const` array)
- speculative config seams / unused `mode` switches / injectable-override defaults nothing needs yet
- additive churn on a cleanup; code that "looks productive" over the minimal change
Expand Down