Update package.xml to remove catkin dependency #263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wxmerkt
commented
Nov 17, 2019
wxmerkt
commented
- We don't need to specify a catkin dependency (and it fails to resolve on ROS2).
- Required for Add octomap to dashing rosdistro #237
- I plan to make a 1.9.1 release using these changes and the 16 commits between 1.9.0 and the current devel
- Also add myself as maintainer for ROS buildfarm notifications
- Also add myself as maintainer for ROS buildfarm notifications
- Also add myself as maintainer for ROS buildfarm notifications
|
Thanks! From your explanations at #237 this should work for both ROS1 and ROS2 for now. I'll take care of the 1.9.1 release. |
|
Thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.