chore: remove Repetier settings leftovers#5328
Merged
foosel merged 3 commits intoOctoPrint:devfrom Mar 23, 2026
Merged
Conversation
Removes leftovers of 86b886e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdto a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
devbranch(no PRs from your version of
main,bugfix,nextordevplease), e.g.
wip/my_new_featureorwip/my_bugfixno dead code, ideally only one commit - rebase and squash your PR
if necessary!
.lesssource files, not the.cssfiles (those are generatedwith
lessc)have added unit tests
nothing broke (
pytest)pre-commitsuite against your changesand nothing broke (
pre-commit run --all-files)AUTHORS.mdfile :)What does this PR do and why is it necessary?
ignoreIdenticalResendsandidenticalResendsCountdownsettings leftovers from config schema, Settings API, and UI. They were removed by 86b886e in 2018.swallowOkAfterResendsetting leftover from Settings API. It was introduced in 2013 by d12da25, and later removed in 2015 by 116a540.This was dead code since years, so of course it's bugfix release relevant.
How was it tested? How can it be tested by the reviewer?
No need to test, this was all dead code.
Edit: CI here failed because of a bug in unit tests (see #5332). Actually,
pytestpasses on my laptop.Was any kind of genAI (ChatGPT, Copilot etc) involved in creating this PR? Which one and how?
No.
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes