Skip to content

chore: remove Repetier settings leftovers#5328

Merged
foosel merged 3 commits intoOctoPrint:devfrom
jacopotediosi:fix/resend-repetition-leftovers
Mar 23, 2026
Merged

chore: remove Repetier settings leftovers#5328
foosel merged 3 commits intoOctoPrint:devfrom
jacopotediosi:fix/resend-repetition-leftovers

Conversation

@jacopotediosi
Copy link
Copy Markdown
Member

@jacopotediosi jacopotediosi commented Mar 20, 2026

  • You have read through CONTRIBUTING.md
  • Your changes are not possible to do through a plugin and relevant
    to a large audience (ideally all users of OctoPrint)
  • If your changes are large or otherwise disruptive: You have
    made sure your changes don't interfere with current development by
    talking it through with the maintainers, e.g. through a
    Brainstorming ticket
  • Your PR targets OctoPrint's dev branch
  • Your PR was opened from a custom branch on your repository
    (no PRs from your version of main, bugfix, next or dev
    please), e.g. wip/my_new_feature or wip/my_bugfix
  • Your PR only contains relevant changes: no unrelated files,
    no dead code, ideally only one commit - rebase and squash your PR
    if necessary!
  • If your changes include style sheets: You have modified the
    .less source files, not the .css files (those are generated
    with lessc)
  • You have tested your changes (please state how!) - ideally you
    have added unit tests
  • You have run the existing unit tests against your changes and
    nothing broke (pytest)
  • You have run the included pre-commit suite against your changes
    and nothing broke (pre-commit run --all-files)
  • You have added yourself to the AUTHORS.md file :)

What does this PR do and why is it necessary?

  1. Remove ignoreIdenticalResends and identicalResendsCountdown settings leftovers from config schema, Settings API, and UI. They were removed by 86b886e in 2018.
  2. Remove swallowOkAfterResend setting leftover from Settings API. It was introduced in 2013 by d12da25, and later removed in 2015 by 116a540.

This was dead code since years, so of course it's bugfix release relevant.

How was it tested? How can it be tested by the reviewer?

No need to test, this was all dead code.
Edit: CI here failed because of a bug in unit tests (see #5332). Actually, pytest passes on my laptop.

Was any kind of genAI (ChatGPT, Copilot etc) involved in creating this PR? Which one and how?

No.

Any background context you want to provide?

What are the relevant tickets if any?

Screenshots (if appropriate)

Further notes

@github-actions github-actions Bot added targets dev The PR targets the dev branch approved Issue has been approved by the bot or manually for further processing labels Mar 20, 2026
This is dead code. It was introduced in 2013 by d12da25, and later removed in 2015 by 116a540.
@jacopotediosi jacopotediosi changed the title chore: remove resend repetition leftovers chore: remove Repetier settings leftovers Mar 20, 2026
@foosel foosel added this to the 2.0.0 milestone Mar 23, 2026
@foosel foosel added the bugfix release relevant Issue should be looked at for backporting into the next bugfix release label Mar 23, 2026
@foosel foosel merged commit 7eece6d into OctoPrint:dev Mar 23, 2026
28 checks passed
@jacopotediosi jacopotediosi deleted the fix/resend-repetition-leftovers branch March 27, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Issue has been approved by the bot or manually for further processing bugfix release relevant Issue should be looked at for backporting into the next bugfix release targets dev The PR targets the dev branch

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants