fix: normalize boolean values consistently#5351
Merged
foosel merged 5 commits intoOctoPrint:devfrom Mar 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.mdto a large audience (ideally all users of OctoPrint)
made sure your changes don't interfere with current development by
talking it through with the maintainers, e.g. through a
Brainstorming ticket
devbranch(no PRs from your version of
main,bugfix,nextordevplease), e.g.
wip/my_new_featureorwip/my_bugfixno dead code, ideally only one commit - rebase and squash your PR
if necessary!
.lesssource files, not the.cssfiles (those are generatedwith
lessc)have added unit tests
nothing broke (
pytest)pre-commitsuite against your changesand nothing broke (
pre-commit run --all-files)AUTHORS.mdfile :)What does this PR do and why is it necessary?
I found that in some parts of the codebase, boolean values were not being obtained/validated/converted checking against
valid_boolean_trues. This could lead to interpreting the stringfalseasTrue, for example when retrieved fromconfig.yamlor from user-provided inputs.This PR fixes all such occurrences.
How was it tested? How can it be tested by the reviewer?
Go to
http://127.0.0.1:5000/reverse_proxy_test/?authenticated=falseBefore this PR, it showed the authenticated version of the reverse proxy test page, even if the
authenticatedparameter wasfalse.After this PR, it correctly shows the unauthenticated version of the page.
Was any kind of genAI (ChatGPT, Copilot etc) involved in creating this PR? Which one and how?
No
Any background context you want to provide?
What are the relevant tickets if any?
Screenshots (if appropriate)
Further notes