Robe/consolidate claude - #2073
Merged
Merged
Conversation
zentron
force-pushed
the
robe/consolidate-claude
branch
2 times, most recently
from
July 22, 2026 11:24
a43dc65 to
a9dc8b2
Compare
zentron
marked this pull request as ready for review
July 22, 2026 11:24
zentron
force-pushed
the
robe/consolidate-claude
branch
from
August 4, 2026 21:58
a9dc8b2 to
abb3315
Compare
MSBuild failed to restore with "Unexpected end-of-file reached inside Calamari.DockerCredentialHelper project section" since the EndProject terminator was missing.
eddymoulton
approved these changes
Aug 5, 2026
eddymoulton
left a comment
eddymoulton
left a comment
Contributor
There was a problem hiding this comment.
Quick question about one line, but otherwise good.
I'll ping @APErebus in slack as well, he had to make a change for the calamari docker image so we should check that we don't need to unmake a change too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we shell directly into claude code cli rather than using libraries, there is no need to seperate out the execution from the main calamari exe.