This repository was archived by the owner on Jun 13, 2025. It is now read-only.
Changed the default package wildcard behavior for create-release#19
Merged
Conversation
…lues to be WildCard rather than empty string (which denotes default package reference only)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command line currently interprets something like
StepA:1.0.0to mean a package reference name of blank string, which means it will only match the default package and not any of the named package references.This is not at all intuitive when dealing with something like
PackageA:1.0.0, which feels like "whichever step PackageA appears in, use version 1.0.0". The wildcard not also spanning package reference names then feels unexpected.This PR changes the default behaviour to assume WildCard rather than "default package reference name".
Fixes OctopusDeploy/Issues#5821