Move button styles to a shared file that can be imported - #3331
Merged
Conversation
rosslovas
marked this pull request as ready for review
August 10, 2026 23:07
enf0rc3
approved these changes
Aug 10, 2026
enf0rc3
left a comment
enf0rc3
left a comment
Contributor
There was a problem hiding this comment.
straightforward lift and shift, will unblock future buttons with shared styles, e.g. copy markdown and select LLM, thankyou!
Approved pending smoke test on staging.
|
Pull request environment is available at https://stoctodocspr3331.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiple components could benefit from these styles. By breaking them out into their own file and using
@import, we get the ability to share while keeping the benefits of scoped styles rather than global styles which run risks of conflicting with the arbitrary specificity of other global styles.