fix(kibana): set pipefail on the readiness probe - #176
Conversation
Follow-up to #173. ansible-lint is right that the journalctl | grep pipe in the Kibana readiness probe should honour \$pipefail — without it, a broken journalctl still lets grep see an empty pipe and exit 1, so we'd fall through to the HTTP check on a machine where journalctl is truly broken. In practice we already had \`|| true\` on the curl call to guard against that, but the linter is enforcing the general rule and the fix is a one-liner.
|
Warning Review limit reached
Next review available in: 29 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Follow-up to #173. ansible-lint is failing on the
journalctl | greppipe I added to the Kibana readiness probe because the shell block does notset -o pipefail. Without it, a brokenjournalctlwould still letgrepsee an empty pipe and exit 1, so the block would fall through to the HTTP check even on a machine wherejournalctlis truly broken.Two-line fix:
set -o pipefailat the top of both readiness probes (main.yml and restart_and_verify_kibana.yml).Also unblocks #171 and #175, both of which were failing lint on this same violation from main.